Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tests don't hang when there's an error in before() block. #9527

Merged
merged 1 commit into from
Dec 7, 2020

Conversation

sainthkh
Copy link
Contributor

@sainthkh sainthkh commented Dec 4, 2020

User facing changelog

Tests don't hang when there's an error in before() block.

Additional details

  • Why was this change necessary? => Test runner stopped when there's an error in before() block.
  • What is affected by this change? => N/A
  • Any implementation details to explain? => Revived the removed getTest() function and checks if the test is pending(skipped).

How has the user experience changed?

N/A

PR Tasks

  • Have tests been added/updated?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 4, 2020

Thanks for taking the time to open a PR!

@sainthkh sainthkh marked this pull request as ready for review December 4, 2020 09:31
@jennifer-shehane jennifer-shehane self-requested a review December 7, 2020 06:02
Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manually confirmed this fixes the hanging in the original issue. The scenario is also tested in the PR. Thanks again @sainthkh! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4.12.1 Regression: after() block causes errors in before() to be hidden
2 participants