Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: merge dev into feat protocol #26909

Merged
merged 27 commits into from
Jun 2, 2023

Conversation

mjhenkes
Copy link
Member

@mjhenkes mjhenkes commented Jun 1, 2023

  • Closes

Additional details

This was largely a straight forward merge except there are now duplicate keys for CLOUD_CANNOT_UPLOAD_ARTIFACTS. Maybe these could be merged into one key, but they are for slightly different purposes so i renamed one CLOUD_CANNOT_UPLOAD_ARTIFACTS_PROTOCOL to not delay merging develop into the feature branch.

Steps to test

How has the user experience changed?

PR Tasks

jordanpowell88 and others added 23 commits May 18, 2023 12:16
* chore: add empty nx.json [run ci]

* chore: add nx cloud runner [run ci]

* chore: add nx-cloud dep [run ci]

* chore: update local nx cloud accessToken to be read-only
* feat(app): update DebugError copy

* feat: set isUsingGit project flag and consume in DebugContainer

* feat(app): update not using git icon for DebugError

* feat(app): displays alert on runs page when not using git

* feat(app): add component for when no runs for current branch

* feat(app): add warning for no runs for branch on runs container

* chore: add feat to CHANGELOG

* chore: remove logged status value

* chore: resolve import from merge conflict

* test(app): stub branch name for e2e runs spec

* chore: add line break in changelog entry

* chore: cleanup PR

* chore: fix i18n import for DebugBranchError

* chore: add utm and update Warning links to inline

* chore: capitalize Git in i18n

* ref: warning liink

* test: add i18n to tests

* test(app): change utm_source assertions

* chore: cleanup pr

* chore: remove unused prop

* test(app): remove no git warning when moving to runs page in e2e

* chore: change template logic

* chore: remove duplicate RUNS_TAB_MEDIUM const

* Changed Debug test assertion and reordered new components for Debug

---------

Co-authored-by: Stokes Player <[email protected]>
* chore: change processing nomenclature to compressing when printing the run.

* chore: rename 'capturing of' to 'capturing'
* chore: rename upload results to upload screenshots & videos

* run ci
* fix: correct typescript scaffold dependency (#26204)

* add changelog

* Update change log for PR comment

Co-authored-by: Mike Plummer <[email protected]>

---------

Co-authored-by: Mike Plummer <[email protected]>
Co-authored-by: Mark Noonan <[email protected]>
* chore: 12.13.0 changelog fix

* remove pending, bump version

* fix typo
Upped the number of operations per run.  Have been manually doing that so this job can get through all the issues in the repo with no problems.
stalebot was incorrectly configured to run in debug mode.  I have updated the default to run in normal mode when running scheduled
* chore: capture telemetry for realworld app maybe

* idk what i was doing

* setup record key and telemetry

* testing

* override project id

* some times we just need a little context.

* Adding tests

* Adding comment
@mjhenkes mjhenkes changed the base branch from develop to feat/protocol June 1, 2023 16:53
@cypress
Copy link

cypress bot commented Jun 1, 2023

Passing run #46961 ↗︎

0 214 20 0 Flakiness 0

Details:

update snapshot text
Project: cypress Commit: b75b4d5b8f
Status: Passed Duration: 10:36 💡
Started: Jun 2, 2023 12:22 PM Ended: Jun 2, 2023 12:33 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@mjhenkes mjhenkes marked this pull request as ready for review June 1, 2023 18:21
@AtofStryker AtofStryker self-requested a review June 1, 2023 23:06
@mjhenkes mjhenkes merged commit 6809d11 into feat/protocol Jun 2, 2023
@mjhenkes mjhenkes deleted the matth/chore/merge-dev-into-feat-protocol branch June 2, 2023 18:55
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 29, 2023

Released in 13.0.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v13.0.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Aug 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.