-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: merge dev into feat protocol #26909
Merged
mjhenkes
merged 27 commits into
feat/protocol
from
matth/chore/merge-dev-into-feat-protocol
Jun 2, 2023
Merged
chore: merge dev into feat protocol #26909
mjhenkes
merged 27 commits into
feat/protocol
from
matth/chore/merge-dev-into-feat-protocol
Jun 2, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* chore: add empty nx.json [run ci] * chore: add nx cloud runner [run ci] * chore: add nx-cloud dep [run ci] * chore: update local nx cloud accessToken to be read-only
* feat(app): update DebugError copy * feat: set isUsingGit project flag and consume in DebugContainer * feat(app): update not using git icon for DebugError * feat(app): displays alert on runs page when not using git * feat(app): add component for when no runs for current branch * feat(app): add warning for no runs for branch on runs container * chore: add feat to CHANGELOG * chore: remove logged status value * chore: resolve import from merge conflict * test(app): stub branch name for e2e runs spec * chore: add line break in changelog entry * chore: cleanup PR * chore: fix i18n import for DebugBranchError * chore: add utm and update Warning links to inline * chore: capitalize Git in i18n * ref: warning liink * test: add i18n to tests * test(app): change utm_source assertions * chore: cleanup pr * chore: remove unused prop * test(app): remove no git warning when moving to runs page in e2e * chore: change template logic * chore: remove duplicate RUNS_TAB_MEDIUM const * Changed Debug test assertion and reordered new components for Debug --------- Co-authored-by: Stokes Player <[email protected]>
* chore: change processing nomenclature to compressing when printing the run. * chore: rename 'capturing of' to 'capturing'
* chore: rename upload results to upload screenshots & videos * run ci
* fix: correct typescript scaffold dependency (#26204) * add changelog * Update change log for PR comment Co-authored-by: Mike Plummer <[email protected]> --------- Co-authored-by: Mike Plummer <[email protected]> Co-authored-by: Mark Noonan <[email protected]>
* chore: 12.13.0 changelog fix * remove pending, bump version * fix typo
Snyk has created this PR to upgrade typescript from 4.7.4 to 4.9.5. See this package in npm: See this project in Snyk: https://app.snyk.io/org/cypress-opensource/project/d5b36925-e6ee-455d-9649-6560a9aca413?utm_source=github&utm_medium=referral&page=upgrade-pr
Upped the number of operations per run. Have been manually doing that so this job can get through all the issues in the repo with no problems.
Co-authored-by: Ben M <[email protected]>
stalebot was incorrectly configured to run in debug mode. I have updated the default to run in normal mode when running scheduled
* chore: capture telemetry for realworld app maybe * idk what i was doing * setup record key and telemetry * testing * override project id * some times we just need a little context. * Adding tests * Adding comment
mschile
approved these changes
Jun 1, 2023
AtofStryker
approved these changes
Jun 2, 2023
3 tasks
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional details
This was largely a straight forward merge except there are now duplicate keys for
CLOUD_CANNOT_UPLOAD_ARTIFACTS
. Maybe these could be merged into one key, but they are for slightly different purposes so i renamed oneCLOUD_CANNOT_UPLOAD_ARTIFACTS_PROTOCOL
to not delay merging develop into the feature branch.Steps to test
How has the user experience changed?
PR Tasks
cypress-documentation
?type definitions
?