Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: capture versions of relevant dependencies with x-dependencies header #26814

Merged
merged 2 commits into from
May 22, 2023

Conversation

astone123
Copy link
Contributor

Additional details

On the initial call to the Cypress manifest, we want to include any relevant dependencies and their versions if they exist in the project using the x-dependencies header.

Steps to test

  1. Create a project that has some of the dependencies in these lists
  2. Open Cypress with DEBUG="cypress:data-context:sources:VersionsDataSource"
  3. Verify that on the initial log that reads retrieving latest version information with headers:, the x-dependencies header is present and contains the correct dependencies and versions that exist in your project, none that don't exist in your project, and none that don't exist in the lists linked above.
  4. Verify that on subsequent requests to the Cypress manifest endpoint, the x-dependencies header is not
    included in the list of headers.

How has the user experience changed?

This should not change the experience for the user.

PR Tasks

@astone123 astone123 requested a review from a team May 19, 2023 19:48
@cypress
Copy link

cypress bot commented May 19, 2023

2 flaky tests on run #46655 ↗︎

0 303 20 0 Flakiness 2

Details:

refactor isDependencyInstalled by name, add tests
Project: cypress Commit: 89f1bd17b4
Status: Passed Duration: 19:35 💡
Started: May 22, 2023 5:45 PM Ended: May 22, 2023 6:04 PM
Flakiness  scaffold-component-testing.cy.ts • 1 flaky test • launchpad-e2e

View Output Video

Test Artifacts
scaffolding component testing > nuxtjs-vue2-unconfigured > scaffolds component testing for Nuxt 2 Output Screenshots Video
Flakiness  global-mode.cy.ts • 1 flaky test • launchpad-e2e

View Output Video

Test Artifacts
... > can be opened Output Screenshots Video

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@mike-plummer mike-plummer requested a review from a team May 22, 2023 14:04
@astone123 astone123 requested a review from mike-plummer May 22, 2023 17:13
Copy link
Contributor

@mike-plummer mike-plummer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice tests!

@mike-plummer mike-plummer requested a review from a team May 22, 2023 17:21
Copy link
Contributor

@marktnoonan marktnoonan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did some manual validation and all looks good!

@astone123 astone123 merged commit 6df7a70 into develop May 22, 2023
@astone123 astone123 deleted the ct-telemetry-v2 branch May 22, 2023 19:59
@cypress-bot
Copy link
Contributor

cypress-bot bot commented May 23, 2023

Released in 12.13.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v12.13.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators May 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants