Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix UI flash when switching to debug page #26761

Merged
merged 2 commits into from
May 17, 2023
Merged

fix: fix UI flash when switching to debug page #26761

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fefd287
fix: fix UI flash when switching to debug page
warrensplayer May 15, 2023
2166036
Adding change log
warrensplayer May 15, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions cli/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ _Released 05/23/2023 (PENDING)_
- Reverted [#26452](https://github.com/cypress-io/cypress/pull/26630) which introduced a bug that prevents users from using End to End with Yarn 3. Fixed in [#26735](https://github.com/cypress-io/cypress/pull/26735). Fixes [#26676](https://github.com/cypress-io/cypress/issues/26676).
- Moved `types` condition to the front of `package.json#exports` since keys there are meant to be order-sensitive. Fixed in [#26630](https://github.com/cypress-io/cypress/pull/26630).
- Fixed an issue where newly-installed dependencies would not be detected during Component Testing setup. Addresses [#26685](https://github.com/cypress-io/cypress/issues/26685).
- Fixed a UI regression that was flashing an "empty" state inappropriately when loading the Debug page. Fixed in [#26761](https://github.com/cypress-io/cypress/pull/26761).

**Misc:**

Expand Down
3 changes: 1 addition & 2 deletions packages/app/src/pages/Debug.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ const cachedProject = ref<DebugSpecsFragment>()
const query = useQuery({ query: DebugDocument, variables, pause: shouldPauseQuery, requestPolicy: 'network-only' })

const isLoading = computed(() => {
const relevantRunsHaveNotLoaded = !relevantRuns.value
const relevantRunsHaveNotLoaded = !relevantRuns.value.all
const queryIsBeingFetched = query.fetching.value

const cloudProject = query.data.value?.currentProject?.cloudProject?.__typename === 'CloudProject'
Expand All @@ -76,7 +76,6 @@ const isLoading = computed(() => {
})

watchEffect(() => {
//console.log('query for debug', query.data.value, relevantRuns.value.commitShas)
if (query.data.value?.currentProject?.cloudProject?.__typename === 'CloudProject') {
const cloudProject = query.data.value.currentProject.cloudProject

Expand Down