Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix UI flash when switching to debug page #26761

Merged
merged 2 commits into from
May 17, 2023

Conversation

warrensplayer
Copy link
Contributor

@warrensplayer warrensplayer commented May 15, 2023

Additional details

This PR fixes a regresssion for the Debug page that was causing an empty state to flash when switching to that page from another page in the app.

Before fix

debug_fix_before.mov

After fix

debug_fix_after.mov

Steps to test

  • Open the App with a project that is connected to the Cloud.
  • Select either E2E or component and open the browser
  • Select the Debug sidebar item
  • The page should show the loading skeleton and then the Debug UI without a quick cycle through another empty state

How has the user experience changed?

PR Tasks

@warrensplayer warrensplayer self-assigned this May 15, 2023
@warrensplayer warrensplayer requested a review from a team May 15, 2023 20:39
@warrensplayer warrensplayer marked this pull request as ready for review May 15, 2023 20:39
@cypress
Copy link

cypress bot commented May 15, 2023

34 flaky tests on run #46331 ↗︎

0 27296 1308 0 Flakiness 34

Details:

Adding change log
Project: cypress Commit: 2166036bf5
Status: Passed Duration: 22:35 💡
Started: May 15, 2023 8:49 PM Ended: May 15, 2023 9:12 PM
Flakiness  create-from-component.cy.ts • 2 flaky tests • app-e2e

View Output Video

Test Artifacts
... > runs generated spec Output Screenshots Video
... > runs generated spec Output Screenshots Video
Flakiness  runs.cy.ts • 1 flaky test • app-e2e

View Output Video

Test Artifacts
App: Runs > Runs - Create Project > when a project is created, injects new projectId into the config file, and sends expected UTM params Output Screenshots Video
Flakiness  specs_list_latest_runs.cy.ts • 1 flaky test • app-e2e

View Output Video

Test Artifacts
App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs Output Screenshots Video
Flakiness  cypress-in-cypress-component.cy.ts • 1 flaky test • app-e2e

View Output Video

Test Artifacts
Cypress In Cypress CT > default config > redirects to the specs list with error if a spec is not found Output Screenshots Video
Flakiness  cypress-origin-communicator.cy.ts • 1 flaky test • app-e2e

View Output Video

Test Artifacts
Cypress In Cypress Origin Communicator > cy.origin passivity with app interactions > passes upon test reload mid test execution Output Screenshots Video

The first 5 flaky specs are shown, see all 20 specs in Cypress Cloud.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@warrensplayer warrensplayer requested a review from a team May 16, 2023 11:15
@warrensplayer warrensplayer merged commit 7fa5103 into develop May 17, 2023
@warrensplayer warrensplayer deleted the stokes/fix_debug_page_regression branch May 17, 2023 19:58
@cypress-bot
Copy link
Contributor

cypress-bot bot commented May 23, 2023

Released in 12.13.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v12.13.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators May 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants