-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: report header stats overlapping issue with 4 digit test count #23469
Conversation
Thanks for taking the time to open a PR!
|
@marktnoonan could you help to make pipeline run on this branch? |
@marktnoonan PR is good for review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine to me, running CI now.
Hi @astone123 @AtofStryker kindly help to take a look at this PR cc: @lmiller1990 |
Thank you for your contribution! I am going to merge this PR. |
This PR was pushed through Gitstart, with contributions from @BikashSah999, @raph941, @phunguyenmurcul. |
User facing changelog
Fixed an bug where icon within stats of reporter header don't account for 4 digit test count. Fixes #21838
Additional details
The number of tests (greater than 999) can't be seen clearly in header since the number used to be overlap with icon
Steps to test
Start cypress app, select the target project and then start E2E testing
Start any specs (even example specs) on the header you can see the number of tests passed/failed
How has the user experience changed?
Before
After
PR Tasks
cypress-documentation
?type definitions
?