Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: report header stats overlapping issue with 4 digit test count #23469

Merged
merged 12 commits into from
Oct 28, 2022

Conversation

gitstart
Copy link
Contributor

@gitstart gitstart commented Aug 19, 2022

User facing changelog

Fixed an bug where icon within stats of reporter header don't account for 4 digit test count. Fixes #21838

Additional details

The number of tests (greater than 999) can't be seen clearly in header since the number used to be overlap with icon

Steps to test

Start cypress app, select the target project and then start E2E testing
Start any specs (even example specs) on the header you can see the number of tests passed/failed

How has the user experience changed?

Before
171220139-2b4f959b-6336-453d-8320-fce29d0a175a

After
Screen Shot 2022-08-08 at 12 54 46

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Aug 19, 2022

Thanks for taking the time to open a PR!

@gitstart gitstart changed the title [CYPRESS-21838] Icons within stats of reporter header don't account for 4 digit test count fix: report header stats overlapping issue with 4 digit test count Aug 19, 2022
@gitstart gitstart marked this pull request as ready for review August 19, 2022 18:34
@gitstart gitstart marked this pull request as draft August 29, 2022 17:02
@gitstart gitstart marked this pull request as ready for review August 29, 2022 17:03
@gitstart
Copy link
Contributor Author

@marktnoonan could you help to make pipeline run on this branch?

@gitstart
Copy link
Contributor Author

gitstart commented Sep 5, 2022

@marktnoonan PR is good for review

@lmiller1990 lmiller1990 self-requested a review September 23, 2022 00:37
Copy link
Contributor

@lmiller1990 lmiller1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me, running CI now.

@lmiller1990 lmiller1990 self-assigned this Sep 23, 2022
@gitstart
Copy link
Contributor Author

Hi @astone123 @AtofStryker kindly help to take a look at this PR

cc: @lmiller1990

@mschile
Copy link
Contributor

mschile commented Oct 28, 2022

Thank you for your contribution! I am going to merge this PR.

@gitstart
Copy link
Contributor Author

gitstart commented Nov 3, 2022

This PR was pushed through Gitstart, with contributions from @BikashSah999, @raph941, @phunguyenmurcul.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icons within stats of reporter header don't account for 4 digit test count
5 participants