Skip to content

Commit

Permalink
fix: report header stats overlapping issue with 4 digit test count (#…
Browse files Browse the repository at this point in the history
  • Loading branch information
gitstart authored Oct 28, 2022
1 parent 9ceb95d commit b3360d6
Show file tree
Hide file tree
Showing 2 changed files with 22 additions and 2 deletions.
4 changes: 2 additions & 2 deletions packages/reporter/src/header/header.scss
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ $color-transition: color 150ms ease-out;
height: 24px;
justify-content: space-between;
padding: 0 4px;
width: 124px;
min-width: 124px;

li {
display: flex;
Expand All @@ -110,7 +110,7 @@ $color-transition: color 150ms ease-out;
color: $white;
line-height: 12px;
vertical-align: text-top;
width: 16px;
min-width: 16px;
display: inline-block;
text-align: center;

Expand Down
20 changes: 20 additions & 0 deletions packages/reporter/src/header/stats.cy.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
import { AppState } from '../lib/app-state'
import { StatsStore } from './stats-store'
import Header from './header'
import React from 'react'

describe('stats score header', () => {
it('Shows stats with more than 4 digit test count nicely', () => {
const appState = new AppState()
const statsStore = new StatsStore()

statsStore.start({ startTime: new Date().toISOString(), numPassed: 999999, numFailed: 999999, numPending: 999999 })
statsStore.end()

cy.mount(
<Header statsStore={statsStore} appState={appState} />,
)

cy.percySnapshot()
})
})

5 comments on commit b3360d6

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on b3360d6 Oct 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the linux x64 version of the Test Runner.

Learn more about this pre-release platform-specific build at https://on.cypress.io/installing-cypress#Install-pre-release-version.

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/10.11.1/linux-x64/develop-b3360d6b29a5d2950824f9b9644760a9da65fadc/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on b3360d6 Oct 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the linux arm64 version of the Test Runner.

Learn more about this pre-release platform-specific build at https://on.cypress.io/installing-cypress#Install-pre-release-version.

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/10.11.1/linux-arm64/develop-b3360d6b29a5d2950824f9b9644760a9da65fadc/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on b3360d6 Oct 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the darwin arm64 version of the Test Runner.

Learn more about this pre-release platform-specific build at https://on.cypress.io/installing-cypress#Install-pre-release-version.

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/10.11.1/darwin-arm64/develop-b3360d6b29a5d2950824f9b9644760a9da65fadc/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on b3360d6 Oct 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the darwin x64 version of the Test Runner.

Learn more about this pre-release platform-specific build at https://on.cypress.io/installing-cypress#Install-pre-release-version.

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/10.11.1/darwin-x64/develop-b3360d6b29a5d2950824f9b9644760a9da65fadc/cypress.tgz

@cypress-bot
Copy link
Contributor

@cypress-bot cypress-bot bot commented on b3360d6 Oct 28, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Circle has built the win32 x64 version of the Test Runner.

Learn more about this pre-release platform-specific build at https://on.cypress.io/installing-cypress#Install-pre-release-version.

Run this command to install the pre-release locally:

npm install https://cdn.cypress.io/beta/npm/10.11.1/win32-x64/develop-b3360d6b29a5d2950824f9b9644760a9da65fadc/cypress.tgz

Please sign in to comment.