cache commands, --no-exit #1875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jennifer-shehane
previously requested changes
Jun 5, 2018
cli/lib/cli.js
Outdated
| program | ||
| .command('cache') | ||
| .usage('[command]') | ||
| .description('Manage the Cypress binary cache') |
There was a problem hiding this comment.
Can you update 'Manage' to 'Manages' to keep in line with other commands having plural verb descriptors, ie: 'Opens ...', 'Installs ...', 'Verifies ...'?
|
Does this also close #817 about |
kuceb
commented
Jun 5, 2018
cli/__snapshots__/cli_spec.js
Outdated
| @@ -105,6 +106,7 @@ exports['cli help command shows help 1'] = ` | |||
| open [options] Opens Cypress in the interactive GUI. | |||
| install [options] Installs the Cypress executable matching this package's version | |||
| verify Verifies that Cypress is installed correctly and executable | |||
| cache [options] Manage the Cypress binary cache | |||
There was a problem hiding this comment.
optimally this should say cache <command>
|
I'm confused why there is code in like |
|
@jennifer-shehane whoops, forgot to remove that commit |
|
@jennifer-shehane fixed |
brian-mann
requested changes
Jun 5, 2018
cli/lib/exec/run.js
Outdated
| @@ -74,6 +74,10 @@ const processRunOptions = (options = {}) => { | |||
| args.push('--headed', options.headed) | |||
| } | |||
|
|
|||
| if (options.noExit) { | |||
| args.push('--no-exit') | |||
There was a problem hiding this comment.
There are no tests for this, and the logic is broken because you're not testing options.exit === false in here
cli/lib/cli.js
Outdated
| .option('--dev', text('dev'), coerceFalse) | ||
| .action((opts) => { | ||
| // console.log(opts) |
cli/lib/cli.js
Outdated
| unknownOption.call(this, `cache ${opts}`, 'sub-command') | ||
| } | ||
| cache[opts]() | ||
| // this.outputHelp() |
brian-mann
approved these changes
Jun 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #1856
cypress cache <command>close #1871
--no-exit