Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not respecting --silent flag on install #817

Closed
KittyGiraudel opened this issue Oct 26, 2017 · 4 comments · Fixed by #1855
Closed

Not respecting --silent flag on install #817

KittyGiraudel opened this issue Oct 26, 2017 · 4 comments · Fixed by #1855
Assignees
@kuceb
Labels
cli good first issue Good for newcomers OS: linux type: unexpected behavior User expected result, but got another
Milestone
3.0.2

Comments

@KittyGiraudel
Copy link
Contributor

  • Operating System: Mac OS
  • Cypress Version: 1+
  • Browser Version: n/A

Is this a Feature or Bug?

A bug.

Current behavior:

When running npm install in silent mode (--silent), Cypress installs itself in verbose mode (installing, unzipping, checking printed out).

Desired behavior:

If npm install is run in silent mode (--silent), Cypress sticks to it and doesn’t output anything upon installation.

How to reproduce:

npm install --silent

Additional Info (images, stack traces, etc)

This is a problem in logs because we end up with thousands of lines of Cypress installing then unzipping itself. Avoiding these kind of logs is why we run npm install in silent mode in the first place.
@jennifer-shehane jennifer-shehane added cli stage: ready for work The issue is reproducible and in scope type: unexpected behavior User expected result, but got another good first issue Good for newcomers labels Oct 26, 2017
@cameronc56
Copy link

npm install --quiet and --silent suppresses the excessive cypress logs on Ubuntu xenial, but NOT debian jessie

@KittyGiraudel KittyGiraudel mentioned this issue Feb 5, 2018
Closed
@kuceb kuceb self-assigned this Jun 1, 2018
@kuceb kuceb mentioned this issue Jun 1, 2018
Closed
@kuceb kuceb added this to the 3.0.2 milestone Jun 1, 2018
@brian-mann brian-mann mentioned this issue Jun 1, 2018
Merged
@jennifer-shehane jennifer-shehane mentioned this issue Jun 5, 2018
Merged
@KittyGiraudel
Copy link
Contributor Author

Nice. :)

@jennifer-shehane jennifer-shehane added stage: pending release and removed stage: ready for work The issue is reproducible and in scope labels Jun 6, 2018
@jennifer-shehane jennifer-shehane added stage: pending release and removed stage: in progress stage: needs investigating Someone from Cypress needs to look at this stage: proposal 💡 No work has been done of this issue stage: needs review The PR code is done & tested, needs review stage: ready for work The issue is reproducible and in scope labels Jun 27, 2018
@brian-mann
Copy link
Member

Released in 3.0.2.

@kuceb
Copy link
Contributor

kuceb commented Nov 1, 2018 •
edited
Loading

On second thought, we shouldn't blanket-disable all of our logging, we should just make sure to keep logging to a minimum. For example, if Cypress is downloading a ~300mb binary, we should tell the user regardless.

Here's puppeteer when installing with --silent
pup

PR here #2706

This was referenced Nov 1, 2018
Closed
Closed
This was referenced Mar 26, 2021
Open
Open
@snyk-bot snyk-bot mentioned this issue Mar 27, 2021
Open
This was referenced Feb 18, 2022
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kuceb kuceb

Labels
cli good first issue Good for newcomers OS: linux type: unexpected behavior User expected result, but got another
Projects
None yet
Milestone
3.0.2
Development

Successfully merging a pull request may close this issue.

env vars from configs, respect loglevel from npm cypress-io/cypress
5 participants
@brian-mann @jennifer-shehane @KittyGiraudel @cameronc56 @kuceb