Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate away from express-graphql package #1420

Closed
astone123 opened this issue Oct 18, 2023 · 2 comments
Closed

Migrate away from express-graphql package #1420

astone123 opened this issue Oct 18, 2023 · 2 comments

Comments

@astone123
Copy link
Contributor

The express-graphql package is deprecated and does not support the version of GraphQL that we're on. We should move off of it to a different GraphQL server package that still allows us to easily standup GraphiQL. Possible candidates

@hiepluong2205
Copy link

+1 for Apollo Server

timheilman added a commit to timheilman/cypress-realworld-app that referenced this issue Mar 5, 2024
cacieprins added a commit that referenced this issue May 20, 2024
#1521)

* build: replace express-graphql with graphql-http and graphql-playground-middleware-express

toward resolution of issue #1420 and #1508

* fix: go ahead and preempt provision of GET at /graphql by graphql-http

with graphql-playground-middleware-express, rather than serving it from GET /gql-playground. This preserves functionality closer to as it was with express-graphql.

* fix: whoops did not mean to modify database.json

* Update backend/app.ts

Co-authored-by: Cacie Prins <[email protected]>

* style: do not pollute type system with one-off inline types

* fix: consume rename commited on github from reviewer suggestion

* style: do not pollute Query.ts either with one-off inline types

* build: empty commit to clear perhaps spurious circleCI failure on firefox

all specs passing on firefox locally.

---------

Co-authored-by: Cacie Prins <[email protected]>
markerikson pushed a commit to replayio-public/cypress-realworld-app that referenced this issue Jun 25, 2024
cypress-io#1521)

* build: replace express-graphql with graphql-http and graphql-playground-middleware-express

toward resolution of issue cypress-io#1420 and cypress-io#1508

* fix: go ahead and preempt provision of GET at /graphql by graphql-http

with graphql-playground-middleware-express, rather than serving it from GET /gql-playground. This preserves functionality closer to as it was with express-graphql.

* fix: whoops did not mean to modify database.json

* Update backend/app.ts

Co-authored-by: Cacie Prins <[email protected]>

* style: do not pollute type system with one-off inline types

* fix: consume rename commited on github from reviewer suggestion

* style: do not pollute Query.ts either with one-off inline types

* build: empty commit to clear perhaps spurious circleCI failure on firefox

all specs passing on firefox locally.

---------

Co-authored-by: Cacie Prins <[email protected]>
@timheilman
Copy link
Contributor

I believe this was resolved by #1521 using graphql-http and graphql-playground

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants