Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

High number of installation warnings - vite #1403

Closed
6 of 13 tasks
MikeMcC399 opened this issue Sep 10, 2023 · 6 comments · Fixed by #1417
Closed
6 of 13 tasks

High number of installation warnings - vite #1403

MikeMcC399 opened this issue Sep 10, 2023 · 6 comments · Fixed by #1417

Comments

@MikeMcC399
Copy link
Contributor

MikeMcC399 commented Sep 10, 2023 •
edited
Loading

Description

Running yarn install produces a large number of warnings.

Steps to reproduce

Clone repo and execute the following under Node.js 18.16.1:

git clean -x -d -f
yarn install

Expectation

There should be no installation warnings produced by yarn install.

Logs

Clean install

$ node -v
v18.16.1

$ yarn install
yarn install v1.22.19
[1/5] Validating package.json...
[2/5] Resolving packages...
[3/5] Fetching packages...
[4/5] Linking dependencies...
warning " > @material-ui/[email protected]" has incorrect peer dependency "react@^16.8.0 || ^17.0.0".
warning " > @material-ui/[email protected]" has incorrect peer dependency "react-dom@^16.8.0 || ^17.0.0".
warning "@material-ui/core > @material-ui/[email protected]" has incorrect peer dependency "react@^16.8.0 || ^17.0.0".
warning "@material-ui/core > @material-ui/[email protected]" has incorrect peer dependency "react-dom@^16.8.0 || ^17.0.0".
warning "@material-ui/core > @material-ui/[email protected]" has incorrect peer dependency "react@^16.8.0 || ^17.0.0".
warning "@material-ui/core > @material-ui/[email protected]" has incorrect peer dependency "react-dom@^16.8.0 || ^17.0.0".
warning "@material-ui/core > @material-ui/[email protected]" has incorrect peer dependency "react@^16.8.0 || ^17.0.0".
warning "@material-ui/core > @material-ui/[email protected]" has incorrect peer dependency "react-dom@^16.8.0 || ^17.0.0".
warning " > @material-ui/[email protected]" has incorrect peer dependency "react@^16.8.0 || ^17.0.0".
warning " > @material-ui/[email protected]" has incorrect peer dependency "react-dom@^16.8.0 || ^17.0.0".
warning " > @material-ui/[email protected]" has incorrect peer dependency "react@^16.8.0 || ^17.0.0".
warning " > @material-ui/[email protected]" has incorrect peer dependency "react-dom@^16.8.0 || ^17.0.0".
warning " > @xstate/[email protected]" has incorrect peer dependency "react@^16.8.0 || ^17.0.0".
warning "aws-amplify > @aws-amplify/core > [email protected]" has unmet peer dependency "react-native@*".
warning "aws-amplify > @aws-amplify/analytics > @aws-sdk/client-firehose > @aws-sdk/middleware-retry > [email protected]" has unmet peer dependency "react-native@>=0.56".
warning " > [email protected]" has incorrect peer dependency "react@^16 || ^17".
warning " > [email protected]" has incorrect peer dependency "react-dom@^16 || ^17".
warning " > [email protected]" has incorrect peer dependency "react@^15.3.0 || ^16.0.0-alpha".
warning "react-infinite-calendar > [email protected]" has incorrect peer dependency "[email protected] || 16.x".
warning "react-infinite-calendar > [email protected]" has incorrect peer dependency "react@^15.0.0 || ^16.0.0".
warning "react-infinite-calendar > [email protected]" has incorrect peer dependency "react-dom@^15.0.0 || ^16.0.0".
warning "react-infinite-calendar > [email protected]" has incorrect peer dependency "react@^0.14.0 || ^15.0.0".
warning " > @babel/[email protected]" has unmet peer dependency "@babel/core@^7.0.0-0".
warning "@babel/plugin-proposal-private-property-in-object > @babel/[email protected]" has unmet peer dependency "@babel/core@^7.0.0".
warning "@babel/plugin-proposal-private-property-in-object > @babel/[email protected]" has unmet peer dependency "@babel/core@^7.0.0-0".
warning "@cypress/code-coverage > @cypress/[email protected]" has unmet peer dependency "@babel/core@^7.0.1".
warning "@cypress/code-coverage > @cypress/[email protected]" has unmet peer dependency "@babel/preset-env@^7.0.0".
warning "@cypress/code-coverage > @cypress/[email protected]" has unmet peer dependency "babel-loader@^8.0.2 || ^9".
warning "@cypress/code-coverage > @cypress/[email protected]" has unmet peer dependency "webpack@^4 || ^5".
warning " > @cypress/[email protected]" has unmet peer dependency "html-webpack-plugin@>=4".
warning " > @cypress/[email protected]" has unmet peer dependency "webpack@>=4".
warning " > @cypress/[email protected]" has unmet peer dependency "webpack-dev-server@>=3.0.0".
warning " > @percy/[email protected]" has incorrect peer dependency "cypress@^3 || ^4 || ^5 || ^6".
warning "eslint-config-react-app > [email protected]" has unmet peer dependency "@babel/plugin-syntax-flow@^7.14.5".
warning "eslint-config-react-app > [email protected]" has unmet peer dependency "@babel/plugin-transform-react-jsx@^7.14.9".
warning " > [email protected]" has incorrect peer dependency "graphql@^14.7.0 || ^15.3.0".
warning Workspaces can only be enabled in private projects.
[5/5] Building fresh packages...
$ husky install && patch-package
husky - Git hooks installed
patch-package 7.0.0
Applying patches...
@material-ui/[email protected] ✔
[email protected] ✔
Done in 275.42s.

Repeat install

$ yarn install
yarn install v1.22.19
[1/5] Validating package.json...
[2/5] Resolving packages...
success Already up-to-date.
$ husky install && patch-package
husky - Git hooks installed
patch-package 7.0.0
Applying patches...
@material-ui/[email protected] ✔
[email protected] ✔
Done in 0.93s.
@MikeMcC399 MikeMcC399 mentioned this issue Sep 10, 2023
Closed
@astone123
Copy link
Contributor

@MikeMcC399 I took a look at this today. In order to resolve these warnings, it looks like we need to do the following:

  • Upgrade Material UI packages to v5
  • Upgrade @xstate/react to 3.0.0
  • Move to a new package for react-google-login as it's no longer maintained and stuck on React 16/17 peer dependencies. Looks like someone forked it and released a version with React 18 peer deps here, might be able to use that
  • Similarly, migrate off of react-infinite-calendar which appears to be unmaintained as well, so its peer dependencies for React are stuck
  • Add unmet peer dependencies (@babel/[email protected], react-native for aws-amplify, webpack, etc)
  • Uninstall @cypress/webpack-dev-server (I don't think we need it anymore)
  • Migrate from express-graphql to graphql-http

As you can tell, most of these were caused by upgrading to React 18 and not updating other packages to get the updated peer dependencies. Some of these changes are pretty straightforward, but things like the Material UI migration is going to be a pretty heavy lift. This work will likely need to be broken out across multiple issues.

@MikeMcC399
Copy link
Contributor Author

@astone123

It's great you've identified the items to tackle. I only got as far as assessing that it was complex and too difficult for me to fix! 😃

@astone123 astone123 mentioned this issue Oct 18, 2023
Merged
@astone123
Copy link
Contributor

I created separate issues for the things that I didn't resolve in #1417

@MikeMcC399
Copy link
Contributor Author

@astone123

Is the remaining aws-amplify warning covered by your new issues listed in #1403 (comment) above ^^?

$ yarn
yarn install v1.22.19
[1/5] Validating package.json...
[2/5] Resolving packages...
[3/5] Fetching packages...
[4/5] Linking dependencies...
warning " > @material-ui/[email protected]" has incorrect peer dependency "react@^16.8.0 || ^17.0.0".
warning " > @material-ui/[email protected]" has incorrect peer dependency "react-dom@^16.8.0 || ^17.0.0".
warning "@material-ui/core > @material-ui/[email protected]" has incorrect peer dependency "react@^16.8.0 || ^17.0.0".
warning "@material-ui/core > @material-ui/[email protected]" has incorrect peer dependency "react-dom@^16.8.0 || ^17.0.0".
warning "@material-ui/core > @material-ui/[email protected]" has incorrect peer dependency "react@^16.8.0 || ^17.0.0".
warning "@material-ui/core > @material-ui/[email protected]" has incorrect peer dependency "react-dom@^16.8.0 || ^17.0.0".
warning "@material-ui/core > @material-ui/[email protected]" has incorrect peer dependency "react@^16.8.0 || ^17.0.0".
warning "@material-ui/core > @material-ui/[email protected]" has incorrect peer dependency "react-dom@^16.8.0 || ^17.0.0".
warning " > @material-ui/[email protected]" has incorrect peer dependency "react@^16.8.0 || ^17.0.0".
warning " > @material-ui/[email protected]" has incorrect peer dependency "react-dom@^16.8.0 || ^17.0.0".
warning " > @material-ui/[email protected]" has incorrect peer dependency "react@^16.8.0 || ^17.0.0".
warning " > @material-ui/[email protected]" has incorrect peer dependency "react-dom@^16.8.0 || ^17.0.0".
warning "aws-amplify > @aws-amplify/core > [email protected]" has unmet peer dependency "react-native@*".
warning "aws-amplify > @aws-amplify/analytics > @aws-sdk/client-firehose > @aws-sdk/middleware-retry > [email protected]" has unmet peer dependency "react-native@>=0.56".
warning " > [email protected]" has incorrect peer dependency "react@^15.3.0 || ^16.0.0-alpha".
warning "react-infinite-calendar > [email protected]" has incorrect peer dependency "[email protected] || 16.x".
warning "react-infinite-calendar > [email protected]" has incorrect peer dependency "react@^15.0.0 || ^16.0.0".
warning "react-infinite-calendar > [email protected]" has incorrect peer dependency "react-dom@^15.0.0 || ^16.0.0".
warning "react-infinite-calendar > [email protected]" has incorrect peer dependency "react@^0.14.0 || ^15.0.0".
warning "@cypress/code-coverage > @cypress/[email protected]" has unmet peer dependency "@babel/preset-env@^7.0.0".
warning "@cypress/code-coverage > @cypress/[email protected]" has unmet peer dependency "babel-loader@^8.0.2 || ^9".
warning " > [email protected]" has incorrect peer dependency "graphql@^14.7.0 || ^15.3.0".
warning Workspaces can only be enabled in private projects.
[5/5] Building fresh packages...
$ husky install && patch-package
husky - Git hooks installed
patch-package 7.0.0
Applying patches...
@material-ui/[email protected] ✔
[email protected] ✔
Done in 162.49s.

@astone123
Copy link
Contributor

@MikeMcC399 it is not... I'm not sure what to do about that one. Installing react-native adds other warnings to the list

@MikeMcC399 MikeMcC399 mentioned this issue Nov 6, 2023
Merged
@MikeMcC399 MikeMcC399 mentioned this issue Jan 6, 2024
Open
@MikeMcC399 MikeMcC399 mentioned this issue Feb 7, 2024
Closed
7 tasks
@MikeMcC399
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: fix some peer dependency warnings cypress-io/cypress-realworld-app
2 participants
@astone123 @MikeMcC399