Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use Node8 with package lock, close #56 #62

Merged
merged 4 commits into from
Sep 12, 2017
Merged

use Node8 with package lock, close #56 #62

merged 4 commits into from
Sep 12, 2017

Conversation

bahmutov
Copy link
Contributor

@bahmutov bahmutov commented Sep 11, 2017 •
edited
Loading

Add package lock file.
Note that you Docker file is on Node 6. The build and tests should still work, but not as reliable as local work

@bahmutov bahmutov requested a review from brian-mann September 11, 2017 16:48
@bahmutov bahmutov merged commit 4c02a62 into develop Sep 12, 2017
@jennifer-shehane jennifer-shehane deleted the node-8-and-package-lock branch October 25, 2017 18:28
bencodezen added a commit that referenced this pull request May 20, 2020
@bencodezen
refactor (#62): centralize pr templates into a single directory
f8f5cf4
bencodezen added a commit that referenced this pull request May 20, 2020
@bencodezen
config (#62): add pr template for plugin pull requests
8b7a467
amirrustam pushed a commit that referenced this pull request Jun 2, 2020
@bencodezen
Config/62 add plugin pr template (#2811)
388a46b 
* refactor (#62): centralize pr templates into a single directory

* config (#62): add pr template for plugin pull requests

* config: update plugin pr template with better language and comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brian-mann brian-mann Awaiting requested review from brian-mann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bahmutov