Skip to content

Commit

Permalink
use Node8 with package lock, close #56 (#62)
Browse files Browse the repository at this point in the history
* use Node8 with package lock, close #56

* switch to Node 8 docker image
  • Loading branch information
bahmutov authored Sep 12, 2017
1 parent 9f5d12f commit 4c02a62
Show file tree
Hide file tree
Showing 6 changed files with 10,918 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .node-version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
6.5.0
8.4.0
2 changes: 2 additions & 0 deletions .npmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
package-lock=true
save-exact=true
3 changes: 3 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,9 @@ cd cypress-documentation

**Install dependencies:**

**note:** at least Node 6 is required, but Node 8 with NPM v5 is preferred to take advantage of
the package lock file.

```bash
npm install
```
Expand Down
4 changes: 2 additions & 2 deletions circle.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@ defaults: &defaults
parallelism: 1
working_directory: ~/cypress-documentation
docker:
# the Docker image with Cypress dependencies and Chrome browser
- image: cypress/internal:chrome58
# the Docker image with Cypress dependencies
- image: cypress/base:8
environment:
<<: *env_defaults

Expand Down
Loading

0 comments on commit 4c02a62

Please sign in to comment.