Issue-2038 #2048
Merged
Issue-2038 #2048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
TonySynenko
commented
Aug 29, 2019
TonySynenko
commented
- close Closable top banner #2038
- close TypeError: Unable to get property 'clientHeight' of undefined or null reference #2034
…bar test after close all banners
…se test if there is no banners at the screen
amirrustam
suggested changes
Aug 29, 2019
|
space added
|
amirrustam
approved these changes
Aug 29, 2019
amirrustam
suggested changes
Aug 29, 2019
There was a problem hiding this comment.
@KateAbramova can you show the test that demonstrates the closable banner applies uniquely to individual banners?
amirrustam
suggested changes
Aug 29, 2019
| const bannerItems = header.find('.top-banners-item') | ||
|
|
||
| cy.get(bannerItems).each(($banner) => { | ||
| notUniquerBanner.includes($banner.attr('id')) |
There was a problem hiding this comment.
.includes only returns a boolean, and is not test assertion here. You can use .have.members or something similar.
There was a problem hiding this comment.
resolved in 79a4c74
| }) | ||
| }) | ||
| }) | ||
|
|
||
| it('Should close each banner with it close button', function () { |
There was a problem hiding this comment.
A typo, should say "...banner with a close button"
There was a problem hiding this comment.
resolved in 79a4c74
jennifer-shehane
requested changes
Aug 29, 2019
There was a problem hiding this comment.
We may want to also add some tests about the banner in mobile view in our mobile_spec https://github.com/cypress-io/cypress-documentation/blob/issue-2038/cypress/integration/mobile_spec.js#L3
Co-Authored-By: Jennifer Shehane <[email protected]>
… exceptions for screens, that have innerWidth less that 768px
jennifer-shehane
approved these changes
Sep 9, 2019
jennifer-shehane
pushed a commit
that referenced
this pull request
Oct 2, 2019
* Fix typo in the cross-origin error section (#2033) Fix typo: s/communicate […] to _bypasses_ all same-origin security policies/communicate […] to _bypass_ all same-origin security policies * chore(deps): Update dependency @types/jest to version 24.0.18 🌟 (#2029) Co-authored-by: Renovate Bot <[email protected]> * add section explaining how to patch Cypress CLI module (#2045) * add section explaining how to patch Cypress CLI module * md lint * Reduce a lot of noise in the patch instructions - It’s a lot, a lot of assumptions on how much people know about how Cypress works and a lot of info specific to the Windows pipe patch that I think will just lead to misdirection. * update error message about stale runs to be more clear * Add instructions on how to uninstall Cypress GitHub app * Add links (#2058) * add instrument-cra plugin link * add another cy.within example * Fix typo * lowercase 'TR' Co-authored-by: Jennifer Shehane <[email protected]> * docs - add missing param (#2061) * Issue-2038 (#2048) * Closable top banner functionality * Closable top banner css fixes * add test for close banner * add close animation * html + css update * update close btn test to close each banner, add algolia test and sidebar test after close all banners * small css fix, add Contentful environment for dev needs, add skip close test if there is no banners at the screen * unnecessary check removal from test * add 5px margin to CTA button * add test for closing one unique banner * fixing contentful_banners_spec issues after review * Update cypress/integration/contentful_banners_spec.js Co-Authored-By: Jennifer Shehane <[email protected]> * added all contentful_banners_spec into mobile_spec, add sidebar tests exceptions for screens, that have innerWidth less that 768px Co-authored-by: Anton Synenko <[email protected]> * add jsconfig section (#2054) * add jsconfig section * VS Code, minor grammar Co-authored-by: Jennifer Shehane <[email protected]> * Update writing-your-first-test.md (#2043) * chore(deps): Update dependency git-last to version 1.2.12 🌟 (#2000) Co-authored-by: Renovate Bot <[email protected]> Co-authored-by: Jennifer Shehane <[email protected]> * chore(deps): Update dependency sinon to version 7.4.2 🌟 (#2052) Co-authored-by: Renovate Bot <[email protected]> * try using v2.1 of Circle * testing trigger by commit * trigger workflow using empty GitHub commit, close #2069 (#2070) * Add support to pt-br (#2065) * add support to pt-br * translate content to pt-br * add translation pt-br to why-cypress * Update logic to copy over en docs to non-translated pt-br pages Co-authored-by: Jennifer Shehane <[email protected]> * add test automation u course (#2075) * Add cypress-rails mention (#2079) * issue 2071 (#2072) Co-authored-by: Anton Synenko <[email protected]> * chore(deps): Update dependency start-server-and-test to version… (#2078) Co-authored-by: Renovate Bot <[email protected]> * Update for new nav (#2076) * Update screenshots and copy to match dashboard's new styles * Delete unused dashboard screenshots * resize image + set css class to have maxwidth of img be 600px * package-lock Co-authored-by: Jennifer Shehane <[email protected]> * Answer how to champion cypress (#2056) * update code coverage FAQ answer * add links to unit testing recipe * add FAQ answer to question how to convince company to use Cypress * move question to English FAQ * Updated some wording on championing cypress faq Co-authored-by: Jennifer Shehane <[email protected]> * add cypress-fiddle link and blurb (#2060) * add cypress-fiddle link and blurb * move cypress fiddle to debugging doc * Minor grammar Co-authored-by: Jennifer Shehane <[email protected]> * wrong podcast link, close #2074 (#2080) * fix(deps): Update dependency hexo-server to version 1.0.0 🌟 (#2053) Co-authored-by: Renovate Bot <[email protected]> * change open to run (#2083) * Remove url that was breaking the groups section shell code * fix(deps): Update dependency contentful to version 7.10.0 🌟 (#2087) Co-authored-by: Renovate Bot <[email protected]> * add vscode extension (#2088) * describe solution to xvfb problem (#2090) * describe solution to xvfb problem * rename known issues section * small text tweaks * add links to native code coverage example and backend cove… (#1788) * WIP: add links to native code coverage example and backend coverage * Use "back end" term * increases max viewport from 3000 to 4000 px
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.