Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closable top banner #2038

Closed
3 tasks done
amirrustam opened this issue Aug 23, 2019 · 2 comments · Fixed by #2048
Closed
3 tasks done

Closable top banner #2038

amirrustam opened this issue Aug 23, 2019 · 2 comments · Fixed by #2048
Assignees

Comments

@amirrustam
Copy link
Contributor

amirrustam commented Aug 23, 2019

  • Add a close "X" icon to the right-end of the top banner to allow users to close the top banner.
  • Utilize localStorage to cache the user's decision to close the banner.
  • Caching of closed banners should be done for each unique banner, and should not apply to all banners.
@amirrustam
Copy link
Contributor Author

@KateAbramova the close link can use a big of refinement on mobile:

Screen Shot 2019-08-28 at 11 33 05 AM

I got the above shot from the test run video. The close icon should have similar left padding to the rest of the content.

@amirrustam
Copy link
Contributor Author

@TonySynenko please check off the todo items within the issue as you're working on it or before the associated PR gets merged. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants