Remove ping mutation #4481
Merged
Remove ping mutation #4481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 28, 2021
What do we still need to do? |
|
The traceback Mel reported is a separate issue I'm working on. The traceback can be reproduced with other mutations if something goes wrong at the cylc-flow resolver end |
hjoliver
approved these changes
Nov 2, 2021
There was a problem hiding this comment.
LGTM, definitely an improvement (in addition to removing ping). Maybe we can improve further in the future, along the lines of @oliver-sanders suggestion.
|
Easy fix to remove the hardcoded list, raised a PR - MetRonnie#11 |
oliver-sanders
approved these changes
Nov 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes partially address cylc/cylc-uiserver#242. Sibling to cylc/cylc-uiserver#270 and cylc/cylc-ui#823
Ping is not needed for the UI, as it must already be connected to the workflow for the UI to show the workflow in the first place. It also turns out there was not a resolver for ping anyway.
Requirements check-list
CONTRIBUTING.mdand added my name as a Code Contributor.setup.pyandconda-environment.yml.