Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ping broken on the gui #242

Closed
datamel opened this issue Sep 2, 2021 · 4 comments
Closed

Ping broken on the gui #242

datamel opened this issue Sep 2, 2021 · 4 comments
Assignees
Labels
bug Something isn't working small superseded

Comments

@datamel
Copy link
Contributor

datamel commented Sep 2, 2021

This appears with master cylc-uiserver, cylc-ui and cylc-flow installed.
Steps to reproduce:

  • Start either cylc gui, jupyter-cylc or cylc hub - issue is present with all three.
  • Play a workflow, useful to run it in --no-detach mode to see the error on screen.
  • From the gui ping the workflow (with the ping button on the menu or from GraphIQL:
mutation {
  ping (workflows: ["workflow_name"]) {
    result
  }
}

You get a traceback error of....

Traceback (most recent call last):
  File "~/miniconda3/envs/cylc-8/lib/python3.7/site-packages/promise/promise.py", line 844, in handle_future_result
    resolve(future.result())
  File "~/cylc-flow/cylc/flowwork/graphql.py", line 426, in async_resolve
    return await next_(root, info, **args)
  File "~/cylc-uiserver/cylc/uiserver/authorise.py", line 416, in async_resolve
    return await next_(root, info, **args)
  File "~/miniconda3/envs/cylc-8/lib/python3.7/site-packages/promise/iterate_promise.py", line 10, in iterate_promise
    yield from promise.future  # type: ignore
  File "~/miniconda3/envs/cylc-8/lib/python3.7/site-packages/promise/promise.py", line 844, in handle_future_result
    resolve(future.result())
  File " ~/cylc-flow/cylc/flowwork/schema.py", line 1277, in mutator
    res = await resolvers.mutator(info, command, w_args, args)
  File " ~/cylc-uiserver/cylc/uiserver/resolvers.py", line 201, in mutator
    'graphql', w_ids, graphql_args
  File " ~/cylc-uiserver/cylc/uiserver/workflows_mgr.py", line 305, in multi_request
    for msg_core in list(val.values())[0].get('result')
graphql.error.located_error.GraphQLLocatedError: 'list' object has no attribute 'values'
@datamel datamel added bug Something isn't working small labels Sep 2, 2021
@oliver-sanders oliver-sanders added this to the cylc-uiserver 0.6.0 milestone Sep 6, 2021
@kinow
Copy link
Member

kinow commented Sep 14, 2021

@datamel I just tried calling it from GraphiQL and didn't get any error?

mutation {
  ping (workflows: ["workflow_name"]) {
    result
  }
}

Are you able to confirm the issue is still occurring, please?

Thanks!

@kinow
Copy link
Member

kinow commented Sep 14, 2021

Oh, broken indeed. Just needed to run that against a running workflow 🤦‍♂️

image

@datamel
Copy link
Contributor Author

datamel commented Sep 14, 2021

Oh, broken indeed. Just needed to run that against a running workflow 🤦‍♂️

Woops, sorry, I should have made that clearer!

@MetRonnie
Copy link
Member

Closed by cylc/cylc-flow#4481, leaving the traceback issue open here: #271

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working small superseded
Projects
None yet
Development

No branches or pull requests

5 participants