Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No recursive installation #4442

Merged
merged 33 commits into from
Nov 22, 2021
Merged

No recursive installation #4442

merged 33 commits into from
Nov 22, 2021

Commits on Oct 13, 2021

  1. added test for not recursing installation

    @wxtim
    wxtim committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    752a6b7 View commit details
    Browse the repository at this point in the history

  2. finished functional testing of prevention of new re

    @wxtim
    wxtim committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    0330010 View commit details
    Browse the repository at this point in the history

  3. Update cylc/flow/workflow_files.py 

    Co-authored-by: Ronnie Dutta <[email protected]>
    @wxtim @MetRonnie
    wxtim and MetRonnie committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    a8035ef View commit details
    Browse the repository at this point in the history

  4. smallfix

    @wxtim
    wxtim committed Oct 13, 2021
    Configuration menu
    Copy the full SHA
    4906e08 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2021

  1. merged check_nested_run_dirs and check_nested_install_dirs

    @wxtim
    wxtim committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    78c042a View commit details
    Browse the repository at this point in the history

  2. fixed so that check nested run dirs doesn't stop you re-installing wo… 

    …rkflow/runX
    @wxtim
    wxtim committed Oct 14, 2021
    Configuration menu
    Copy the full SHA
    817f1f5 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2021

  1. small fix

    @wxtim
    wxtim committed Oct 15, 2021
    Configuration menu
    Copy the full SHA
    0313333 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2021

  1. Apply suggestions from code review 

    Co-authored-by: Ronnie Dutta <[email protected]>
    @wxtim @MetRonnie
    wxtim and MetRonnie authored Oct 18, 2021
    Configuration menu
    Copy the full SHA
    0f3e038 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2021

  1. Removed look_down

    @wxtim
    wxtim authored Oct 20, 2021
    Configuration menu
    Copy the full SHA
    ec12bcb View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2021

  1. Merge branch 'master' into no-recursive-installation

    @wxtim
    wxtim authored Oct 21, 2021
    Configuration menu
    Copy the full SHA
    c7f06dc View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2021

  1. fix test

    @wxtim
    wxtim committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    7a56bb2 View commit details
    Browse the repository at this point in the history

  2. fixed tests, removed downward scanning which never happened anyway

    @wxtim
    wxtim committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    a244469 View commit details
    Browse the repository at this point in the history

  3. fixed tests, removed downward scanning which never happened anyway

    @wxtim
    wxtim committed Oct 26, 2021
    Configuration menu
    Copy the full SHA
    21cb7ef View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2021

  1. Merge branch 'master' into no-recursive-installation

    @wxtim
    wxtim authored Oct 27, 2021
    Configuration menu
    Copy the full SHA
    926c073 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2021

  1. fix Ronnie's broken example - reinstated the downward checking

    @wxtim
    wxtim committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    82ffaf3 View commit details
    Browse the repository at this point in the history

  2. don't check for recursive installation on re-install

    @wxtim
    wxtim committed Nov 2, 2021
    Configuration menu
    Copy the full SHA
    641e5d9 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2021

  1. fixed test which relied on nested installations.

    @wxtim
    wxtim committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    677675e View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2021

  1. merge

    @wxtim
    wxtim committed Nov 10, 2021
    Configuration menu
    Copy the full SHA
    e1aa043 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2021

  1. Update tests/unit/test_workflow_files.py 

    Co-authored-by: Ronnie Dutta <[email protected]>
    @wxtim @MetRonnie
    wxtim and MetRonnie authored Nov 15, 2021
    Configuration menu
    Copy the full SHA
    1fc9f46 View commit details
    Browse the repository at this point in the history

  2. fix review comments

    @wxtim
    wxtim committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    85fc0d1 View commit details
    Browse the repository at this point in the history

  3. fixed error str

    @wxtim
    wxtim committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    61eab94 View commit details
    Browse the repository at this point in the history

  4. fix - make sure sibling check is _NOT_ carried out on cylc-run dir

    @wxtim
    wxtim committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    3542c12 View commit details
    Browse the repository at this point in the history

  5. removed check for sibling installations

    @wxtim
    wxtim committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    1c67985 View commit details
    Browse the repository at this point in the history

  6. removed check for sibling installations

    @wxtim
    wxtim committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    30361f0 View commit details
    Browse the repository at this point in the history

  7. fix shellcheck on Macos

    @wxtim
    wxtim committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    e2fdc2b View commit details
    Browse the repository at this point in the history

  8. disabled unhelpful shellcheck warning

    @wxtim
    wxtim committed Nov 15, 2021
    Configuration menu
    Copy the full SHA
    6299e8f View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2021

  1. reinstate missing test, fixed sibling?

    @wxtim
    wxtim committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    b520f1c View commit details
    Browse the repository at this point in the history

  2. actually check install dirs for recursion

    @wxtim
    wxtim committed Nov 16, 2021
    Configuration menu
    Copy the full SHA
    46dc312 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into no-recursive-installation

    @wxtim
    wxtim authored Nov 16, 2021
    Configuration menu
    Copy the full SHA
    8578129 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2021

  1. Fix duplicate check for nested dirs on install

    @MetRonnie
    MetRonnie committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    6aaae2a View commit details
    Browse the repository at this point in the history

  2. Revert test changes

    @MetRonnie
    MetRonnie committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    6afc948 View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2021

  1. Merge pull request #33 from MetRonnie/patch-pr-4442 

    Fix duplicate check for nested dirs
    @wxtim
    wxtim authored Nov 19, 2021
    Configuration menu
    Copy the full SHA
    19fd599 View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2021

  1. Update CHANGES.md

    @wxtim
    wxtim authored Nov 22, 2021
    Configuration menu
    Copy the full SHA
    b77890a View commit details
    Browse the repository at this point in the history