No recursive installation #4442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wxtim
force-pushed
the
no-recursive-installation
branch
from
66ee2aa
to
8736e6a
Compare
MetRonnie
reviewed
Oct 4, 2021
|
Converted back into a draft pending a re-examination after reviewing #4448 |
wxtim
force-pushed
the
no-recursive-installation
branch
from
2de8d29
to
cd8693e
Compare
|
@MetRonnie I've done a fair re-write... Sorry. |
MetRonnie
reviewed
Oct 7, 2021
wxtim
force-pushed
the
no-recursive-installation
branch
from
cd8693e
to
93790a3
Compare
datamel
reviewed
Oct 13, 2021
wxtim
force-pushed
the
no-recursive-installation
branch
from
b9a7022
to
4906e08
Compare
MetRonnie
reviewed
Oct 13, 2021
wxtim
force-pushed
the
no-recursive-installation
branch
from
bc7d0ca
to
78c042a
Compare
MetRonnie
requested changes
Nov 15, 2021
|
@datamel - much water has passed under the bridge since your last review. Might I ask you to have another look. |
|
@datamel You might want to wait until after I've opened my PR against this PR, will contain a couple of fixes |
Fix duplicate check for nested dirs
|
@datamel This is ready for review |
MetRonnie
reviewed
Nov 19, 2021
MetRonnie
approved these changes
Nov 22, 2021
datamel
approved these changes
Nov 22, 2021
There was a problem hiding this comment.
No problems spotted. Code read, manually tested and run the tests locally.
Thanks @wxtim and @MetRonnie!
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes close #4396
CONTRIBUTING.mdand added my name as a Code Contributor.setup.pyandconda-environment.yml.