Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source move inv resource creation to Build from EnterNotify #623

Merged
merged 4 commits into from
Sep 13, 2024
Merged

Source move inv resource creation to Build from EnterNotify #623

merged 4 commits into from
Sep 13, 2024

Conversation

nuclearkatie
Copy link
Contributor

Closes #622

@nuclearkatie nuclearkatie requested a review from gonuke September 5, 2024 18:38
@nuclearkatie nuclearkatie self-assigned this Sep 5, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 5, 2024 •
edited
Loading

Build Status Report - 517f7fa - 2024-09-13 03:28:55 +0000

Build FROM cyclus_20.04_apt/cyclus:latest
  • Cycamore: Success ✅
  • Cymetric: Success ✅
Build FROM cyclus_20.04_apt/cyclus:stable
  • Cycamore: Failure ❌
  • Cymetric: Skipped due to upstream failure ⚠️
Build FROM cyclus_20.04_conda/cyclus:latest
  • Cycamore: Success ✅
  • Cymetric: Success ✅
Build FROM cyclus_20.04_conda/cyclus:stable
  • Cycamore: Failure ❌
  • Cymetric: Skipped due to upstream failure ⚠️
Build FROM cyclus_22.04_apt/cyclus:latest
  • Cycamore: Success ✅
  • Cymetric: Success ✅
Build FROM cyclus_22.04_apt/cyclus:stable
  • Cycamore: Failure ❌
  • Cymetric: Skipped due to upstream failure ⚠️
Build FROM cyclus_22.04_conda/cyclus:latest
  • Cycamore: Success ✅
  • Cymetric: Success ✅
Build FROM cyclus_22.04_conda/cyclus:stable
  • Cycamore: Failure ❌
  • Cymetric: Skipped due to upstream failure ⚠️

@nuclearkatie nuclearkatie marked this pull request as ready for review September 5, 2024 19:06
@nuclearkatie
Copy link
Contributor Author

Tests won't pass on this until #621 is merged because that PR updates the call to GetFillMass

gonuke
gonuke requested changes Sep 13, 2024
View reviewed changes
Copy link
Member

@gonuke gonuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

quick thought on maintainingg consistency between archetypes for now

src/source.cc Outdated Show resolved Hide resolved
gonuke
gonuke approved these changes Sep 13, 2024
View reviewed changes
Copy link
Member

@gonuke gonuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nuclearkatie

@gonuke gonuke merged commit 4eb716e into cyclus:main Sep 13, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gonuke gonuke gonuke approved these changes

Assignees

@nuclearkatie nuclearkatie

Labels
None yet
Projects
None yet
Milestone
Bulk-to-Discrete packaging
Development

Successfully merging this pull request may close these issues.

Source should not create inventory in EnterNotify() gets called more than once
2 participants
@nuclearkatie @gonuke