Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Source should not create inventory in EnterNotify() gets called more than once #622

Closed
nuclearkatie opened this issue Sep 5, 2024 · 0 comments · Fixed by #623
Closed

Source should not create inventory in EnterNotify() gets called more than once #622

nuclearkatie opened this issue Sep 5, 2024 · 0 comments · Fixed by #623
Assignees
@nuclearkatie
Labels
Defect
Milestone
Bulk-to-Discrete ...

Comments

@nuclearkatie
Copy link
Contributor

Source was moved to a resource buffer system in #613, where the inventory gets created in the EnterNotify(). However, EnterNotify() gets called more than once, so multiple resources of the full inventory get created, which can be confusing. Move the inventory resource creation to Build() instead, which is only called once.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nuclearkatie nuclearkatie

Labels
Defect
Projects
None yet
Milestone
Bulk-to-Discrete packaging
Development

Successfully merging a pull request may close this issue.

Source move inv resource creation to Build from EnterNotify nuclearkatie/cycamore
1 participant
@nuclearkatie