Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix recorded reactor initial demand #538

Merged
merged 1 commit into from
Jul 8, 2022

Conversation

nuclearkatie
Copy link
Contributor

The reactor records initial demand (t=0) as a series of individual demands equal to the number of assemblies in the core plus fresh assemblies requested to keep on hand. However an error meant that the mass request associated with each each assembly demand was equal to the core + fresh assembly mass

E.g. a reactor with 3 assemblies in the core plus 1 on hand, each 1 kg, would previously record 4 separate requests for 3 kg at t=0. After this PR, it will correctly issue 4 separate requests for 1 kg each.

This keeps each individual request to the correct mass of assem_size

Closes #514, thanks @danielwojtaszek for already having an issue open when I stumbled upon this myself

Copy link
Member

@gonuke gonuke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. There are probably prototype configurations where this would create growing errors throughout the simulation!

@gonuke
Copy link
Member

gonuke commented Jul 8, 2022

This also points out a lack of testing infrastructure for recorded quantities like this, I think!

@gonuke gonuke merged commit 57ea917 into cyclus:master Jul 8, 2022
nuclearkatie added a commit to nuclearkatie/cycamore that referenced this pull request Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect demand for initial reactor core recorded in output file
2 participants