fix recorded reactor initial demand #538
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reactor records initial demand (t=0) as a series of individual demands equal to the number of assemblies in the core plus fresh assemblies requested to keep on hand. However an error meant that the mass request associated with each each assembly demand was equal to the core + fresh assembly mass
E.g. a reactor with 3 assemblies in the core plus 1 on hand, each 1 kg, would previously record 4 separate requests for 3 kg at t=0. After this PR, it will correctly issue 4 separate requests for 1 kg each.
This keeps each individual request to the correct mass of
assem_size
Closes #514, thanks @danielwojtaszek for already having an issue open when I stumbled upon this myself