Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect demand for initial reactor core recorded in output file #514

Closed
danielwojtaszek opened this issue Dec 12, 2019 · 2 comments · Fixed by #538
Closed

Incorrect demand for initial reactor core recorded in output file #514

danielwojtaszek opened this issue Dec 12, 2019 · 2 comments · Fixed by #538

Comments

@danielwojtaszek
Copy link

danielwojtaszek commented Dec 12, 2019

The demand for initial core fuel for a reactor recorded in the output file appears to be the full core mass in each row that represents a single assembly. A simple fix would be to change the following line to record assem_size instead of assem_size * n_assem_order. See https://groups.google.com/forum/#!topic/cyclus-users/6Zv9eSAShYw for input files that demonstrate this issue.

cyclus::toolkit::RecordTimeSeries<double>("demand"+fuel_incommods[max_index], this,

assem_size * n_assem_order) ;

Cheers.

Dan

@nuclearkatie
Copy link
Contributor

Was an associated PR ever made for this? I don't see one and I can still replicate the issue

@danielwojtaszek
Copy link
Author

I don't think so. I didn't create one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants