-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Round end roads are rendered over cycleway #154
Comments
This is probably valid for any wire display (foot ways here : https://www.cyclosm.org/#map=19/47.79712/-3.48149/cyclosm, https://www.cyclosm.org/#map=18/47.79712/-3.48149/cyclosm): roads should be displayed first. |
Quite related issue with motorways trunk as well: https://www.cyclosm.org/#map=18/47.04951/-1.63764/cyclosm. |
@Phyks You're right, the road network should be displayed in reverse importance order, motorways first, path last. |
Well no, as we do a cycle map, cycleway must be over other roads :). Though other roads (may be not path) should be render from primary to track) |
That's why you have to display the other network first to display cycle ways on top. |
Not sure what happened but #154 (comment) is now fixed on its own. Concerning #154 (comment), we want cycle infrastructure to always be on top. What was misleading is that the Remaining issue is the original one (#154 (comment)), located at https://www.cyclosm.org/#map=18/48.85436/2.34440/cyclosm. Pont Saint-Michel being a bridge, there is not much possibility to make it go underneath the cycleway with the current layers. Quick fix could be to remove the round ending for bridges? Otherwise, this is quite the same issue as #136 and the only fix I can think of at the moment is moving the cycleways to dedicated layers. |
Sounds good to me. I don't see any side effect. |
I think there is possible side effects, but worth a try. |
Not easy to fix, no Openstreetmap-carto has this quite enigmatic comment https://github.com/gravitystorm/openstreetmap-carto/blob/master/roads.mss#L1107-L1108 which we might dig into. They don't have this issue in the render, so they probably do it right https://www.openstreetmap.org/#map=18/48.85327/2.34692&layers=N. |
Because path are rendered under main highway osm.org don't have the issue we see in your try. |
I think regular path (not bicycle=designated) can be rendered under main highway in CyclOSM too. |
You seem to render bridges before cycle ways. If you render bridges after, it may be correct: render normal network (outside bridges) then render bridges but this includes cycleways on bridges, it may be difficult to do. I get one part of the comment you mentioned (if you render something with transparency several times it changes the transparency, that's why it "glows"), not the second part (why changing line-cap forces multiple rendering, I guess it has to do with the Mapnik rendering engine, maybe the issue is solved now). If you look at the cycling map on osm.org, https://www.openstreetmap.org/#map=18/48.85327/2.34625&layers=CN, they seem to display the cycleways last with transparency. It took me some time to see what was ugly, yes the Petit-Pont. But I don't known how the path can be on the bridge at one side and under on the other end. Sure the way is just a line, not a closed area but if you look at the imagery, the path should be perpendicular to the bridge and therefore you shouldn't have this ugly effect. At Pont Saint-Michel you have a road bridge (layer=1) displayed after a foot bridge. Another edge case! |
We should not, bridges are in this layer while the regular cycleways are on this layer below.
They however seem to have similar issues on the next bridge :) https://www.openstreetmap.org/#map=18/48.85390/2.34429&layers=CN |
link to #192 |
Updated: Summary of this issue
Round ends of bridges are rendered over cycleways, see https://www.cyclosm.org/#map=17/48.85438/2.34576/cyclosm.
Possible solutions:
No further solution at this point :/
Petit pont or Pont St Michel, Paris
The text was updated successfully, but these errors were encountered: