Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dash road surface is rendered over cycle track #136

Closed
Florimondable opened this issue Jun 4, 2019 · 1 comment · Fixed by #350
Closed

Dash road surface is rendered over cycle track #136

Florimondable opened this issue Jun 4, 2019 · 1 comment · Fixed by #350
Labels
bug Something isn't working

Comments

@Florimondable
Copy link
Member

See there rue Tilsit https://cyclosm.github.io/cyclosm-cartocss-style/example.html#18/48.87447/2.29676

@Phyks Phyks added the bug Something isn't working label Jun 4, 2019
@Phyks
Copy link
Member

Phyks commented Jun 24, 2019

This is happening because "Rue Tilsitt" has a separate cycleway which is bidirectional and overflowing on top of the "Rue Tilsitt" (this is expected).

Somehow, it seems attachments are drawn separately, which means

  1. first the "Rue Tilsitt" surface is drawn
  2. the cycleway surface is drawn, overflowing on the "Rue Tilsitt"
  3. the surface of the "Rue Tilsitt" is drawn, overflowing back on top of the cycleway

Not sure exactly why this is happening here. https://tilemill-project.github.io/tilemill/docs/guides/symbol-drawing-order/ has an enigmatic sentence at the very end

If you want to ensure lines are always below fills, use separate attachments.

http://gis.19327.n8.nabble.com/attachment/5340415/0/MapnikXMLDescription.pdf page 28 has some extra details

StyleName Elements are listed in the order they are to be applied to each data source. It should be noted that when you have more than one style and or data source, the precedence of what get rendered first and in what order can lead to unexpected results. Especially if the styles have overlapping rules and symbolizers.

Datasource Elements are listed in the order that you want them processed, remembering that all the listed StyleName Elements are processed against a Datasource before moving to the next source.

But there is no information of the order of rendering within a DataSource.

Having #141 and #115, it could be tempting to put cycleways in a separate layer, but this would probably be an issue for tunnel (cycleways under a tunnel, typically here https://cyclosm.github.io/cyclosm-cartocss-style/example.html#18/48.84040/2.37496). Note that we cannot simply discard cycleways with tunnel=yes or we would discard the whole cycleway here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants