Add statefulset invalid error metrics #421
Closed
+12
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: d-kuro <[email protected]>
d-kuro
force-pushed
the
d-kuro/sts-invalid
branch
from
8d0e142 to
b780310
Compare
d-kuro
commented
Jul 13, 2022
| @@ -968,6 +968,9 @@ func (r *MySQLClusterReconciler) reconcileV1StatefulSet(ctx context.Context, req | |||
| if needRecreate { | |||
| metrics.StatefulSetRecreateErrorTotal.WithLabelValues(cluster.Name, cluster.Namespace).Inc() | |||
| } | |||
| if apierrors.IsInvalid(err) { | |||
There was a problem hiding this comment.
I was going to write a test, but couldn't figure out how to cause this with the current MySQLCluster spec.
Is there a better way?
There was a problem hiding this comment.
@d-kuro
Sorry, I misunderstood the specification of the MySQLCluster.
Certainly, the invalid update will not happen...
May I close this PR?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #265
Added metrics to show re-creation counts when StatefulSet re-creation is supported.
This Pull Request adds metrics for the number of times an update of the immutable field in the StatefulSet has resulted in an error.
This allows users to detect unrecoverable StatefulSet update errors.