Add statefulset invalid error metrics

Signed-off-by: d-kuro <[email protected]>
cybozu-go · Jul 13, 2022 · b780310 · b780310
1 parent 21a21ce
commit b780310
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/controllers/mysqlcluster_controller.go b/controllers/mysqlcluster_controller.go
@@ -968,6 +968,9 @@ func (r *MySQLClusterReconciler) reconcileV1StatefulSet(ctx context.Context, req
 		if needRecreate {
 			metrics.StatefulSetRecreateErrorTotal.WithLabelValues(cluster.Name, cluster.Namespace).Inc()
 		}
+		if apierrors.IsInvalid(err) {
+			metrics.StatefulSetInvalidErrorTotal.WithLabelValues(cluster.Name, cluster.Namespace).Inc()
+		}
 		return fmt.Errorf("failed to reconcile stateful set: %w", err)
 	}
 

diff --git a/pkg/metrics/metrics.go b/pkg/metrics/metrics.go
@@ -26,6 +26,7 @@ var (
 	VolumeResizedErrorTotal       *prometheus.CounterVec
 	StatefulSetRecreateTotal      *prometheus.CounterVec
 	StatefulSetRecreateErrorTotal *prometheus.CounterVec
+	StatefulSetInvalidErrorTotal  *prometheus.CounterVec
 )
 
 // Backup related metrics
@@ -191,4 +192,12 @@ func Register(registry prometheus.Registerer) {
 		Help:      "The number of failed StatefulSet recreates",
 	}, []string{"name", "namespace"})
 	registry.MustRegister(StatefulSetRecreateErrorTotal)
+
+	StatefulSetInvalidErrorTotal = prometheus.NewCounterVec(prometheus.CounterOpts{
+		Namespace: metricsNamespace,
+		Subsystem: clusteringSubsystem,
+		Name:      "statefulset_invalid_errors_total",
+		Help:      "The number of invalid error was returned updating a StatefulSet",
+	}, []string{"name", "namespace"})
+	registry.MustRegister(StatefulSetInvalidErrorTotal)
 }