Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed remove underlying pixels feature #7637

Merged
merged 2 commits into from
Mar 26, 2024

Conversation

klakhov
Copy link
Contributor

@klakhov klakhov commented Mar 19, 2024

Motivation and context

There is a bug in remove underlying pixels feature. If we enable a feature while drawing a mask it wouldnt be applied. Only the next drawn mask will use the feature.
That happens because core config is not updated properly

How has this been tested?

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • [ ] I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@klakhov klakhov requested a review from bsekachev as a code owner March 19, 2024 11:26
@klakhov klakhov added the ui/ux label Mar 19, 2024
Copy link

codecov bot commented Mar 19, 2024

Codecov Report

Merging #7637 (d2cf68e) into develop (f513aa1) will decrease coverage by 0.01%.
Report is 2 commits behind head on develop.
The diff coverage is n/a.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7637      +/-   ##
===========================================
- Coverage    83.47%   83.46%   -0.01%     
===========================================
  Files          373      373              
  Lines        39739    39723      -16     
  Branches      3741     3741              
===========================================
- Hits         33171    33154      -17     
- Misses        6568     6569       +1     
Components Coverage Δ
cvat-ui 79.27% <ø> (-0.02%) ⬇️
cvat-server 87.32% <100.00%> (-0.01%) ⬇️

@klakhov klakhov requested a review from nmanovic as a code owner March 20, 2024 07:03
@bsekachev bsekachev merged commit 087a7ea into develop Mar 26, 2024
34 checks passed
g-kartik pushed a commit to g-kartik/cvat that referenced this pull request Mar 29, 2024
@cvat-bot cvat-bot bot mentioned this pull request Apr 2, 2024
@bsekachev bsekachev deleted the kl/fix-remove-underlying-pixels branch April 15, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants