Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Datumaro version #4984

Merged
merged 4 commits into from
Sep 26, 2022
Merged

Update Datumaro version #4984

merged 4 commits into from
Sep 26, 2022

Conversation

yasakova-anastasia
Copy link
Contributor

@yasakova-anastasia yasakova-anastasia commented Sep 21, 2022

Motivation and context

  • Updated Datumaro version
  • Added Datumaro Skeleton annotation type

How has this been tested?

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

@yasakova-anastasia
Copy link
Contributor Author

/check

@github-actions
Copy link
Contributor

github-actions bot commented Sep 21, 2022

✔️ All checks completed successfully
📄 See logs here

@cvat-ai cvat-ai deleted a comment from github-actions bot Sep 21, 2022
Comment on lines 19 to 20
from datumaro.components.dataset import Dataset
from datumaro.components.media import ByteImage, Image, PointCloud
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check if using import datumaro as dm is reasonable here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated. But it doesn't work for PointCloud.

# --no-binary=datumaro: workaround for pip to install
# opencv-headless instead of regular opencv, to actually run setup script
datumaro==0.2.0 --no-binary=datumaro
git+https://github.com/cvat-ai/datumaro
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This link leads to the develop branch. I don't think it is a good solution, better to specify a branch or commit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@sizov-kirill
Copy link
Contributor

/check

@github-actions
Copy link
Contributor

github-actions bot commented Sep 26, 2022

✔️ All checks completed successfully
📄 See logs here

Copy link
Contributor

@sizov-kirill sizov-kirill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nmanovic nmanovic merged commit 9e67bcb into develop Sep 26, 2022
@nmanovic nmanovic deleted the ay/datumaro-update branch September 26, 2022 14:01
@nmanovic nmanovic mentioned this pull request Dec 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants