Fix project import with skeletons #4867
Conversation
yasakova-anastasia
requested review from
zhiltsov-max and
nmanovic
as code owners
yasakova-anastasia
changed the title
yasakova-anastasia
changed the title
yasakova-anastasia
changed the title
|
@yasakova-anastasia For fixing full check, need to merge develop branch, because it has critical changes |
|
/check |
|
❌ Some checks failed |
|
/check |
|
✔️ All checks completed successfully |
There was a problem hiding this comment.
I have one bug on my side, here is steps to reproduce.
- Create project with skeleton
- Create task in project with video
- Add skeleton track
- Go to the frame with number
last_frame - 10 - Mark one point of skeleton as
outsideon this frame - Save annotations
- Export dataset for project (save_images = True)
- Import exported dataset
Result: An outside property is not appeared in an imported task
|
@kirill-sizov, thanks. Fixed. |
|
/check |
|
❌ Some checks failed |
|
/check |
|
✔️ All checks completed successfully |
|
Full check can be considered as green for this PR, the reason why is was red currently unknown, but I've created issue about this problem. |
There was a problem hiding this comment.
Functionality works fine (in develop environment) , code changes looks good to me.
And I want to mention two things:
- Need to fix project export (KeyError) in separate PR;
- Currently CVAT format it's really hard to support, this contains 1.3k lines of code, a lot of code duplication, almost 200
ifstatements. It's hard to review and difficult to extend. I think if we planing to extend this format in future with new shapes or something else we should to refactorcvat.pyfirst.
| @@ -41,6 +41,7 @@ In annotation mode each image tag has `width` and `height` attributes for the sa | |||
| <attributes> | |||
| <attribute> | |||
| <name>String: attribute name</name> | |||
| <type>String: any, bbox, cuboid, cuboid_3d, ellipse, polygon, polyline, points, skeleton, tag</type> | |||
There was a problem hiding this comment.
Is it for attributes? I believe it is a type for the label itself.
There was a problem hiding this comment.
Fixed, thanks
|
/check |
|
❌ Some checks failed |
Motivation and context
Depends on #4984
How has this been tested?
Checklist
developbranchcvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.