Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation update, added info about the cloud storage UI #3724

Merged
merged 9 commits into from
Oct 4, 2021

Conversation

amotovx
Copy link
Contributor

@amotovx amotovx commented Sep 24, 2021

Motivation and context

Related to #3372

This PR adds an overview page for the Cloud storage tab and instructions on attaching cloud storage using the UI to the Basics section of the manual. The creating an annotation task page has also been updated to reflect the changes.

How has this been tested?

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

@amotovx amotovx requested a review from nmanovic as a code owner September 24, 2021 11:44
title: 'Attach cloud storage'
linkTitle: 'Attach cloud storage'
weight: 21
description: ''
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
description: ''
description: 'Instructions on how to attach cloud storage with use UI.'


- [AWS-S3](https://docs.aws.amazon.com/AmazonS3/latest/userguide/GetStartedWithS3.html):

- `Bucket` - container name cloud storage
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `Bucket` - container name cloud storage
- `Bucket` - cloud storage bucket name


</br>
- `Manifest` - the path to the manifest file on your cloud storage.
You can add multiple file manifests using the add manifest button.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You can add multiple file manifests using the add manifest button.
You can add multiple file manifests using the `Add manifest` button.

@@ -76,6 +76,8 @@ If you select tab `Connected file share` you can choose files for annotation fro
If you select ` Remote source` , you'll see a field where you can enter a list of URLs (one URL per line).
If you upload a video or dataset with images and select `Use cache` option, you can attach a `manifest.jsonl` file.
You can find how to prepare it [here](/docs/manual/advanced/dataset_manifest/).
If you select the 'Cloud Storage' tab, you can select a cloud storage (for this type the cloud storage name),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
If you select the 'Cloud Storage' tab, you can select a cloud storage (for this type the cloud storage name),
If you select the `Cloud Storage` tab, you can select a cloud storage (for this type the cloud storage name),

description: 'Instructions on how to attach cloud storage using UI'
---

In CVAT you can use AWS-S3 and Azur Blob Container cloud storages to store image datasets for your tasks.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we prepare a tutorial here? Let's try to create "AWS account", "load images to S3", "prepare the manifest", "load manifest to S3", "use the storage to create tasks on CVAT.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Users should be able to reproduce our steps. For now we have only description for the complex process.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is also a good idea to get a pubic dataset for the purpose.

Comment on lines 63 to 64
You can mount the cloud storage using command line interface. More information is available on the
[Mounting cloud storage](/docs/administration/advanced/mounting_cloud_storages) page.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It does not correspond to the current functionality and it may mislead a user that the created cloud storage will appear on the page with cloud storages, but it is not like that. So I guess to remove this.

- `Account name`
- `SAS token`

- [`Anonymous access`](https://docs.microsoft.com/en-us/azure/storage/blobs/anonymous-read-access-prevent)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- [`Anonymous access`](https://docs.microsoft.com/en-us/azure/storage/blobs/anonymous-read-access-prevent)
- [`Anonymous access`](https://docs.microsoft.com/en-us/azure/storage/blobs/anonymous-read-access-configure?tabs=portal)

@Marishka17
Copy link
Contributor

@amotovx , Hi, what the current status of the PR?

Copy link
Contributor

@Marishka17 Marishka17 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have only one small comment. Could you please fix it? and I will approve the PR.

description: 'Overview of the cloud storages page.'
---

![](/images/image227.jpg)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess to insert screen with real cloud storage preview. And also mention that such preview
image
will appear when it is impossible to get a real preview (e.g. storage is empty or invalid credentials were used)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess It's better to use svg than the screenshot. What do you think? Also, I don't see it on the website with documentation. This link was used. Am I doing something wrong?

Copy link
Contributor

@TOsmanov TOsmanov Oct 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed the preview of the site, there was a mistake. I think using svg in this case is not convenient because for the correct display need to specify the css styles

@nmanovic
Copy link
Contributor

nmanovic commented Oct 4, 2021

@dmitriikhurtin , could you please confirm that all issues with tests in the PR are known?

@nmanovic nmanovic merged commit 4d8172c into cvat-ai:develop Oct 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants