Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI support cloud storage #3372

Merged
merged 117 commits into from
Sep 17, 2021
Merged

UI support cloud storage #3372

merged 117 commits into from
Sep 17, 2021

Conversation

Marishka17
Copy link
Contributor

@Marishka17 Marishka17 commented Jun 28, 2021

Motivation and context

Dependent on PR
Dependent on PR
Related issue: #863

How has this been tested?

TODOs

  • fix search
  • cards with equal size
  • update query (when creating storage and go to the page of all storages there is no update, need update page manually)
  • add support for an access key, secret key pair for AWS S3 (instead of/or access key, secret key, session token set)
  • clear task form after the task was created
  • cloud storage creating a page
  • cloud storage updating page
  • cloud storage listing page
  • new tab on creating task page
  • manually tested creating && updating cloud storages (S3 and credentials, S3 and anonymous access, Azure Blob container and credentials) && creating tasks with images from a cloud storage
  • correctly updating credentials
  • fix e2e test
  • modernize the structure of the data tree
  • fix all comments after team demonstration

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

@Marishka17 Marishka17 requested a review from bsekachev June 28, 2021 07:59
@Marishka17 Marishka17 requested a review from nmanovic as a code owner June 28, 2021 07:59
@Marishka17
Copy link
Contributor Author

  • Can manifest files be detected automatically? I guess just searching in the root directory and its subdirectories can cover most of the cases.

Surely this can be accomplished by filtering using the corresponding SDK, but manually specifying the required manifests was discussed in the last demo of the solution.

  • Can a custom S3 server be selected, for example as it did in Cyberduck for example?

I'm not really sure about this, I'll check

@Marishka17
Copy link
Contributor Author

@nmanovic , @ActiveChooN

  • default selected manifest on the task creating page
  • select all files on a task creating page

@Marishka17 Marishka17 changed the title [WIP] UI support cloud storage UI support cloud storage Sep 15, 2021
@@ -195,7 +195,6 @@ export default function CreateCloudStorageForm(props: Props): JSX.Element {

if (cloudStorage) {
cloudStorageData.id = cloudStorage.id;
// TODO: it may be coincide with the real account name
Copy link
Contributor Author

@Marishka17 Marishka17 Sep 15, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was my delusion. I checked the documentation and the fake data cannot coincide with the real ones because in real ones lowercase letters can only be used.

@nmanovic
Copy link
Contributor

@Marishka17 , probably an item to investigate after the PR is merged. A list of storages (I have only one) is loading longer than list of tasks (~10 tasks).

@Marishka17
Copy link
Contributor Author

Marishka17 commented Sep 17, 2021

@Marishka17 , probably an item to investigate after the PR is merged. A list of storages (I have only one) is loading longer than list of tasks (~10 tasks).

I think it might be related to getting storage status. I added making "dynamic" loading to do for the future, but for this, I would like to consult with @bsekachev (by the way, I implemented this at the beginning, but it was not entirely correct), so I corrected this moment and did it by analogy with loading previews. Therefore, the customer sees the spin until the server returns not only information about the storage, but also a preview and current status.

@nmanovic nmanovic merged commit 9a53879 into develop Sep 17, 2021
@nmanovic nmanovic deleted the ui_support_cloud_storage branch September 17, 2021 11:17
@Marishka17
Copy link
Contributor Author

@aschernov Hi, could I ask you to add documentation for this feature?

@aschernov
Copy link
Contributor

@Marishka17 , sure. We'll update the documentation

@TOsmanov
Copy link
Contributor

TOsmanov commented Sep 24, 2021

I found that the cloud storage element on the cloud storage page has an image that has the wrong cropping:
image
if the page width <1366 px:
image
The image is displayed after creating a task using this cloud storage. Similar items on the projects page are displayed correctly.

I used "azur blob container" I managed to create a task using images, but I can't create a task using video. In process creating a task appears:
"Could not fetch cloud storage data"

In the console:
image

@Marishka17
Copy link
Contributor Author

I found that the cloud storage element on the cloud storage page has an image that has the wrong cropping:

Thanks. Could you please create a issue?

I used "azur blob container" I managed to create a task using images, but I can't create a task using video.

For this functionality can be used only dataset with images

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problems with CloudStorage support
6 participants