[cvat-core] support cloud storage #3313
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsekachev
reviewed
Jun 15, 2021
|
The cvat-core part looks fine. Let's wait for server part to be merged and during UI development see if the API should be adjusted for convenience. |
Marishka17
changed the title
|
There are |
bsekachev
previously approved these changes
Aug 12, 2021
cvat-core/src/session.js
Outdated
Comment on lines
1571
to
1576
| set: (cloudStorageId) => { | ||
| if (!Number.isInteger(cloudStorageId) || cloudStorageId <= 0) { | ||
| throw new ArgumentError('Value must be a positive integer'); | ||
| } | ||
| data.cloud_storage_id = cloudStorageId; | ||
| }, |
There was a problem hiding this comment.
Since we can't change cloudStorageId, I would suggest to do this field readonly (cloud_storage_id is set via constructor now). What do you think?
bsekachev
changed the title
…error message from the server
bsekachev
changed the title
bsekachev
reviewed
Aug 31, 2021
cvat-core/src/session.js
Outdated
Comment on lines
1547
to
1552
| // set: (cloudStorageId) => { | ||
| // if (!Number.isInteger(cloudStorageId) || cloudStorageId <= 0) { | ||
| // throw new ArgumentError('Value must be a positive integer'); | ||
| // } | ||
| // data.cloud_storage_id = cloudStorageId; | ||
| // }, |
There was a problem hiding this comment.
Do you need this commented code?
Marishka17
changed the title
yes, I will add tests |
Marishka17
changed the title
bsekachev
approved these changes
Sep 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and context
Related issue: #863
TODOs:
Depends on Extension of cloud storage server part #3386
How has this been tested?
Checklist
developbranch- [ ] I have updated the documentation accordinglycvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.