-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add attributes in VOC format #1792
Conversation
Pull Request Test Coverage Report for Build 6157
💛 - Coveralls |
@zhiltsov-max 1 issue is here: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@azhavoro , could you please look? |
I don't know if we should fail or just log if there is an incorrect attribute value. |
@zhiltsov-max could you fix tests? |
Here is an overview of what got changed by this pull request: Complexity increasing per file
==============================
- datumaro/datumaro/plugins/voc_format/converter.py 4
- datumaro/datumaro/plugins/voc_format/extractor.py 2
See the complete overview on Codacy |
@azhavoro, done. |
* Add voc attributes * Allow any values for voc pose * update changelog * Add attribute conversion * linter * fix tests
Motivation and context
Closes #1518
Allows any values in
pose
object attribute.Allows to read and write annotation attributes in
attributes
element of VOC XML annotations.Exporting is enabled by default and can be disabled with
--allow-attributes=False
CLI option of Datumaro export.How has this been tested?
Checklist
develop
branchcvat-core, cvat-data and cvat-ui)
License
Feel free to contact the maintainers if that's a concern.