Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow attributes in COCO format #1782

Merged
merged 5 commits into from
Jun 30, 2020
Merged

Allow attributes in COCO format #1782

merged 5 commits into from
Jun 30, 2020

Conversation

zhiltsov-max
Copy link
Contributor

@zhiltsov-max zhiltsov-max commented Jun 22, 2020 •
edited
Loading

Depends on #1792

Motivation and context

Closes #1337

Allows to read and write annotation attributes in attributes field of COCO annotations.

Exporting is enabled by default and can be disabled with --allow-attributes=False CLI option of Datumaro export.

How has this been tested?

Unit tests

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

@coveralls
Copy link

coveralls commented Jun 22, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 6193

  • 13 of 17 (76.47%) changed or added relevant lines in 2 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.06%) to 65.162%
Changes Missing Coverage Covered Lines Changed/Added Lines %
datumaro/datumaro/plugins/coco_format/converter.py 10 12 83.33%
datumaro/datumaro/plugins/coco_format/extractor.py 3 5 60.0%
Files with Coverage Reduction New Missed Lines %
datumaro/datumaro/plugins/coco_format/converter.py 3 87.76%
Totals Coverage Status
Change from base Build 6185: 0.06%
Covered Lines: 11050
Relevant Lines: 16548
💛 - Coveralls

@azhavoro
Copy link
Contributor

@zhiltsov-max there is the same issue with checkbox as for VOC attributes #1792 .

nmanovic
nmanovic previously approved these changes Jun 24, 2020
View reviewed changes
Copy link
Contributor

@nmanovic nmanovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nmanovic
Copy link
Contributor

@azhavoro , could you please look?

@zhiltsov-max zhiltsov-max changed the title Allow attributes in COCO format [WIP] Allow attributes in COCO format Jun 24, 2020
@zhiltsov-max zhiltsov-max changed the title [WIP] Allow attributes in COCO format [Dependent] Allow attributes in COCO format Jun 24, 2020
@zhiltsov-max zhiltsov-max changed the title [Dependent] Allow attributes in COCO format Allow attributes in COCO format Jun 26, 2020
@nmanovic Codacy Production
Copy link
Contributor

Codacy Here is an overview of what got changed by this pull request:

Complexity increasing per file
==============================
- datumaro/datumaro/plugins/coco_format/extractor.py  2

See the complete overview on Codacy

@nmanovic nmanovic merged commit 80ed45b into develop Jun 30, 2020
@bsekachev bsekachev deleted the zm/coco-attributes branch July 3, 2020 09:31
@rnekk2 rnekk2 mentioned this pull request Jul 6, 2020
Closed
frndmg pushed a commit to signatrix/cvat that referenced this pull request Aug 5, 2020
@zhiltsov-max
Allow attributes in COCO format (cvat-ai#1782)
fee07e5 
* allow attributes in coco

* update changelog

* update cli

* update coco cli
@zhiltsov-max zhiltsov-max mentioned this pull request Aug 13, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmanovic nmanovic nmanovic approved these changes

@azhavoro azhavoro azhavoro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Save object attributes in MS COCO format
4 participants
@zhiltsov-max @coveralls @azhavoro @nmanovic