Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GT annotations can sometimes show up in the Standard mode #8627

Closed
2 tasks done
zhiltsov-max opened this issue Oct 31, 2024 · 0 comments · Fixed by #8675
Closed
2 tasks done

GT annotations can sometimes show up in the Standard mode #8627

zhiltsov-max opened this issue Oct 31, 2024 · 0 comments · Fixed by #8675
Labels
bug Something isn't working ui/ux

Comments

@zhiltsov-max
Copy link
Contributor

zhiltsov-max commented Oct 31, 2024

Actions before raising this issue

  • I searched the existing issues and did not find anything similar.
  • I read/searched the docs

Steps to Reproduce

In a task with honeypots, GT annotations can show up in the UI, when an annotation job is just opened. It can happen on the first opening of the job or later. If a mode is switched, e.g. to Review, the GT annotations correctly disappear, until the show conflicts button is pressed.

image

Expected Behavior

No response

Possible Solution

No response

Context

No response

Environment

@zhiltsov-max zhiltsov-max added bug Something isn't working ui/ux labels Oct 31, 2024
klakhov added a commit that referenced this issue Nov 13, 2024
<!-- Raise an issue to propose your change
(https://github.com/cvat-ai/cvat/issues).
It helps to avoid duplication of efforts from multiple independent
contributors.
Discuss your ideas with maintainers to be sure that changes will be
approved and merged.
Read the [Contribution guide](https://docs.cvat.ai/docs/contributing/).
-->

<!-- Provide a general summary of your changes in the Title above -->

### Motivation and context
<!-- Why is this change required? What problem does it solve? If it
fixes an open
issue, please link to the issue here. Describe your changes in detail,
add
screenshots. -->
Resolves #8627

To reproduce the issue:
1. Create task with gt/honeypots
2. Add annotations to gt job
3. Go to normal job in review mode, enable show gt annotations
4. Go back to the task open the same job/another job
5. Gt annotations will be visible in standard mode
### How has this been tested?
<!-- Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc. -->


### Checklist
<!-- Go over all the following points, and put an `x` in all the boxes
that apply.
If an item isn't applicable for some reason, then ~~explicitly
strikethrough~~ the whole
line. If you don't do that, GitHub will show incorrect progress for the
pull request.
If you're unsure about any of these, don't hesitate to ask. We're here
to help! -->
- [x] I submit my changes into the `develop` branch
- [x] I have created a changelog fragment <!-- see top comment in
CHANGELOG.md -->
- ~~[ ] I have updated the documentation accordingly~~
- ~~[ ] I have added tests to cover my changes~~
- [x] I have linked related issues (see [GitHub docs](

https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword))
- [x] I have increased versions of npm packages if it is necessary

([cvat-canvas](https://github.com/cvat-ai/cvat/tree/develop/cvat-canvas#versioning),

[cvat-core](https://github.com/cvat-ai/cvat/tree/develop/cvat-core#versioning),

[cvat-data](https://github.com/cvat-ai/cvat/tree/develop/cvat-data#versioning)
and

[cvat-ui](https://github.com/cvat-ai/cvat/tree/develop/cvat-ui#versioning))

### License

- [x] I submit _my code changes_ under the same [MIT License](
https://github.com/cvat-ai/cvat/blob/develop/LICENSE) that covers the
project.
  Feel free to contact the maintainers if that's a concern.


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Bug Fixes**
- Resolved an issue preventing ground truth annotations from displaying
in standard mode.

- **Improvements**
- Enhanced job closure functionality to reset ground truth visibility
when a job is closed.
- Improved handling of image filters to maintain the current processed
image state upon successful job retrieval.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ui/ux
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant