Skip to content

Commit

Permalink
Fix: Gt annotations can be shown in standard mode (#8675)
Browse files Browse the repository at this point in the history
<!-- Raise an issue to propose your change
(https://github.com/cvat-ai/cvat/issues).
It helps to avoid duplication of efforts from multiple independent
contributors.
Discuss your ideas with maintainers to be sure that changes will be
approved and merged.
Read the [Contribution guide](https://docs.cvat.ai/docs/contributing/).
-->

<!-- Provide a general summary of your changes in the Title above -->

### Motivation and context
<!-- Why is this change required? What problem does it solve? If it
fixes an open
issue, please link to the issue here. Describe your changes in detail,
add
screenshots. -->
Resolves #8627

To reproduce the issue:
1. Create task with gt/honeypots
2. Add annotations to gt job
3. Go to normal job in review mode, enable show gt annotations
4. Go back to the task open the same job/another job
5. Gt annotations will be visible in standard mode
### How has this been tested?
<!-- Please describe in detail how you tested your changes.
Include details of your testing environment, and the tests you ran to
see how your change affects other areas of the code, etc. -->


### Checklist
<!-- Go over all the following points, and put an `x` in all the boxes
that apply.
If an item isn't applicable for some reason, then ~~explicitly
strikethrough~~ the whole
line. If you don't do that, GitHub will show incorrect progress for the
pull request.
If you're unsure about any of these, don't hesitate to ask. We're here
to help! -->
- [x] I submit my changes into the `develop` branch
- [x] I have created a changelog fragment <!-- see top comment in
CHANGELOG.md -->
- ~~[ ] I have updated the documentation accordingly~~
- ~~[ ] I have added tests to cover my changes~~
- [x] I have linked related issues (see [GitHub docs](

https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword))
- [x] I have increased versions of npm packages if it is necessary

([cvat-canvas](https://github.com/cvat-ai/cvat/tree/develop/cvat-canvas#versioning),

[cvat-core](https://github.com/cvat-ai/cvat/tree/develop/cvat-core#versioning),

[cvat-data](https://github.com/cvat-ai/cvat/tree/develop/cvat-data#versioning)
and

[cvat-ui](https://github.com/cvat-ai/cvat/tree/develop/cvat-ui#versioning))

### License

- [x] I submit _my code changes_ under the same [MIT License](
https://github.com/cvat-ai/cvat/blob/develop/LICENSE) that covers the
project.
  Feel free to contact the maintainers if that's a concern.


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Bug Fixes**
- Resolved an issue preventing ground truth annotations from displaying
in standard mode.

- **Improvements**
- Enhanced job closure functionality to reset ground truth visibility
when a job is closed.
- Improved handling of image filters to maintain the current processed
image state upon successful job retrieval.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
  • Loading branch information
klakhov authored Nov 13, 2024
1 parent 0b528df commit 6d929fa
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
4 changes: 4 additions & 0 deletions changelog.d/20241111_142755_klakhov_fix_show_gt.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
### Fixed

- Ground truth annotations can be shown in standard mode
(<https://github.com/cvat-ai/cvat/pull/8675>)
5 changes: 4 additions & 1 deletion cvat-ui/src/reducers/settings-reducer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -444,8 +444,11 @@ export default (state = defaultState, action: AnyAction): SettingsState => {

return {
...state,

imageFilters: filters,
shapes: {
...state.shapes,
showGroundTruth: false,
},
};
}
case AnnotationActionTypes.INTERACT_WITH_CANVAS: {
Expand Down

0 comments on commit 6d929fa

Please sign in to comment.