Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

navigate over unresolved issues #7443

Closed
2 tasks done
ArMaxik opened this issue Feb 5, 2024 · 10 comments
Closed
2 tasks done

navigate over unresolved issues #7443

ArMaxik opened this issue Feb 5, 2024 · 10 comments
Assignees
@thekavikumar
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@ArMaxik
Copy link

ArMaxik commented Feb 5, 2024

Actions before raising this issue

  • I searched the existing issues and did not find anything similar.
  • I read/searched the docs

Is your feature request related to a problem? Please describe.

There are a some resolved issues in the job. I've gone through the annotations and added some new issues. Now annotator to fix them should somehow find all frames with unresolved issues.

In the latest version of cvat (2.10.2) this is impossible. There is only a way to navigate over frames with issues (both resolved and unresolved):
image

If there are a lot of resolved issues, it's hard and annoying to find frames with new issues.

Describe the solution you'd like

Cheking show/hide resolved issue should also hide frames with them:
image

This will allow you to skip frames with unresolved issues.

Describe alternatives you've considered

No response

Additional context

No response
@ArMaxik ArMaxik added the enhancement New feature or request label Feb 5, 2024
@nmanovic nmanovic added the good first issue Good for newcomers label Mar 5, 2024
@tahamukhtar20
Copy link
Contributor

tahamukhtar20 commented Mar 10, 2024 •
edited
Loading

@bsekachev @nmanovic can you assign please me this issue?

@tahamukhtar20
Copy link
Contributor

tahamukhtar20 commented Mar 11, 2024 •
edited
Loading

@ArMaxik can you please help me recreate the issue?
Like some small steps that I could follow to create some issues, how you would like this to behave, and everything.
And some details on what is needed and what should be happening here.

@ArMaxik
Copy link
Author

ArMaxik commented Mar 13, 2024 •
edited
Loading

@tahamukhtar20 Glad to hear you are working on this issue!
Small steps:

  1. As a reviewer open a job and create some issues.
  2. As an annotator fix issues and resolve them. Or the reviewer can resolve them, it doesn't matter
  3. As a reviewer I found new mistakes, so create some new issues on the same job.
  4. As an annotator, I want to find new issues and skip already resolved. Now it is impossible, I should look through all of them.

There is a perfect button "show/hide resolved issues", but buttons "find the next/previous frame with issues" ignore it

@thekavikumar
Copy link
Contributor

@nmanovic @bsekachevv is the issue still open, if so can you please assign it to me

@nmanovic
Copy link
Contributor

@thekavikumar , the issue was already assigned. @tahamukhtar20 , could you please confirm that you are working on it?

@tahamukhtar20
Copy link
Contributor

@nmanovic you can unassign. I am not able to work on this currently. Thanks

@nmanovic
Copy link
Contributor

@thekavikumar , please let me know if you want to take the issue.

@thekavikumar
Copy link
Contributor

@nmanovic yeah, I will take the issue

thekavikumar added a commit to thekavikumar/cvat that referenced this issue Mar 21, 2024
@thekavikumar
resolved issue cvat-ai#7443
b57249f
@thekavikumar thekavikumar mentioned this issue Mar 21, 2024
Closed
7 tasks
thekavikumar added a commit to thekavikumar/cvat that referenced this issue Mar 21, 2024
@thekavikumar
resolved issue cvat-ai#7443
b5989f3
thekavikumar added a commit to thekavikumar/cvat that referenced this issue Mar 21, 2024
@thekavikumar
resolved cvat-ai#7443
ec9f5e7
thekavikumar added a commit to thekavikumar/cvat that referenced this issue Mar 21, 2024
@thekavikumar
Revert "resolved cvat-ai#7443"
07142de 
This reverts commit ec9f5e7.
thekavikumar added a commit to thekavikumar/cvat that referenced this issue Mar 21, 2024
@thekavikumar
Revert "Revert "resolved cvat-ai#7443""
7121045 
This reverts commit 07142de.
thekavikumar added a commit to thekavikumar/cvat that referenced this issue Mar 21, 2024
@thekavikumar
resolved issue cvat-ai#7443
57050c3
@thekavikumar thekavikumar mentioned this issue Mar 21, 2024
Merged
7 tasks
thekavikumar added a commit to thekavikumar/cvat that referenced this issue Mar 21, 2024
@thekavikumar
resolved issue cvat-ai#7443
5858a60
thekavikumar added a commit to thekavikumar/cvat that referenced this issue Mar 22, 2024
@thekavikumar
resolved isseu cvat-ai#7443
e2e2cd1
klakhov pushed a commit that referenced this issue Apr 12, 2024
@thekavikumar
[GSoC2024] resolved issue #7443 (navigate over unresolved issues) (#7653
f1d308e 
)

Resolved issue #7443 

It skips the frames where all issues have been resolved!

### Checklist
<!-- Go over all the following points, and put an `x` in all the boxes
that apply.
If an item isn't applicable for some reason, then ~~explicitly
strikethrough~~ the whole
line. If you don't do that, GitHub will show incorrect progress for the
pull request.
If you're unsure about any of these, don't hesitate to ask. We're here
to help! -->
- [x] I submit my changes into the `develop` branch
- [x] I have created a changelog fragment <!-- see top comment in
CHANGELOG.md -->
- [x] I have updated the documentation accordingly
- [x] I have added tests to cover my changes
- [x] I have linked related issues (see [GitHub docs](

https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword))
- [x] I have increased versions of npm packages if it is necessary

([cvat-canvas](https://github.com/opencv/cvat/tree/develop/cvat-canvas#versioning),

[cvat-core](https://github.com/opencv/cvat/tree/develop/cvat-core#versioning),

[cvat-data](https://github.com/opencv/cvat/tree/develop/cvat-data#versioning)
and

[cvat-ui](https://github.com/opencv/cvat/tree/develop/cvat-ui#versioning))

### License

- [x] I submit _my code changes_ under the same [MIT License](
https://github.com/opencv/cvat/blob/develop/LICENSE) that covers the
project.
  Feel free to contact the maintainers if that's a concern.
@thekavikumar
Copy link
Contributor

@nmanovic @klakhov please close this issue as it has been resolved!

@klakhov
Copy link
Contributor

klakhov commented Apr 13, 2024

Resolved in #7653

@klakhov klakhov closed this as completed Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thekavikumar thekavikumar

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@ArMaxik @nmanovic @thekavikumar @klakhov @tahamukhtar20