Skip to content

Commit

Permalink
[GSoC2024] resolved issue #7443 (navigate over unresolved issues) (#7653
Browse files Browse the repository at this point in the history
)

Resolved issue #7443 

It skips the frames where all issues have been resolved!

### Checklist
<!-- Go over all the following points, and put an `x` in all the boxes
that apply.
If an item isn't applicable for some reason, then ~~explicitly
strikethrough~~ the whole
line. If you don't do that, GitHub will show incorrect progress for the
pull request.
If you're unsure about any of these, don't hesitate to ask. We're here
to help! -->
- [x] I submit my changes into the `develop` branch
- [x] I have created a changelog fragment <!-- see top comment in
CHANGELOG.md -->
- [x] I have updated the documentation accordingly
- [x] I have added tests to cover my changes
- [x] I have linked related issues (see [GitHub docs](

https://help.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword))
- [x] I have increased versions of npm packages if it is necessary

([cvat-canvas](https://github.com/opencv/cvat/tree/develop/cvat-canvas#versioning),

[cvat-core](https://github.com/opencv/cvat/tree/develop/cvat-core#versioning),

[cvat-data](https://github.com/opencv/cvat/tree/develop/cvat-data#versioning)
and

[cvat-ui](https://github.com/opencv/cvat/tree/develop/cvat-ui#versioning))

### License

- [x] I submit _my code changes_ under the same [MIT License](
https://github.com/opencv/cvat/blob/develop/LICENSE) that covers the
project.
  Feel free to contact the maintainers if that's a concern.
  • Loading branch information
thekavikumar authored Apr 12, 2024
1 parent b13191d commit f1d308e
Show file tree
Hide file tree
Showing 3 changed files with 29 additions and 7 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
### Fixed

- `Find next frame with issues` ignored `hide resolved issues` setting
(<https://github.com/opencv/cvat/pull/7653>)
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,11 @@ export default function LabelsListComponent(): JSX.Element {
const ready = useSelector((state: CombinedState) => state.annotation.canvas.ready);
const activeControl = useSelector((state: CombinedState) => state.annotation.canvas.activeControl);

let frames = issues.map((issue: Issue): number => issue.frame).sort((a: number, b: number) => +a - +b);
let frames = issues
.filter((issue: Issue) => !issuesResolvedHidden || !issue.resolved)
.map((issue: Issue) => issue.frame)
.sort((a: number, b: number) => +a - +b);

if (showGroundTruth) {
const conflictFrames = conflicts
.map((conflict): number => conflict.frame).sort((a: number, b: number) => +a - +b);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -291,6 +291,18 @@ context('Review pipeline feature', () => {
cy.get('.cvat-issues-sidebar-previous-frame').should('be.visible').click();
cy.checkFrameNum(1);

cy.goCheckFrameNumber(1);
cy.collectIssueLabel().then((issueLabelList) => {
for (let label = 0; label < issueLabelList.length; label++) {
cy.resolveIssue(issueLabelList[label], 'Resolved issue');
}
});
cy.goCheckFrameNumber(0);
cy.get('.cvat-issues-sidebar-hidden-resolved-status').click();
cy.get('.cvat-issues-sidebar-next-frame').should('be.visible').click();
cy.checkFrameNum(2);
cy.get('.cvat-issues-sidebar-hidden-resolved-status').click();

// Hide all issues. All issues are hidden on all frames
cy.get('.cvat-issues-sidebar-shown-issues').click();
for (const [frame, issues] of countIssuesByFrame) {
Expand All @@ -311,12 +323,14 @@ context('Review pipeline feature', () => {

// Comment issues and resolve them
for (const [frame] of countIssuesByFrame) {
cy.goCheckFrameNumber(frame);
cy.collectIssueLabel().then((issueLabelList) => {
for (let label = 0; label < issueLabelList.length; label++) {
cy.resolveIssue(issueLabelList[label], 'Resolved issue');
}
});
if (frame !== 1) {
cy.goCheckFrameNumber(frame);
cy.collectIssueLabel().then((issueLabelList) => {
for (let label = 0; label < issueLabelList.length; label++) {
cy.resolveIssue(issueLabelList[label], 'Resolved issue');
}
});
}
}

cy.setJobState('completed');
Expand Down

0 comments on commit f1d308e

Please sign in to comment.