Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: closes #955. fixed issue with stretched #1004

Merged
merged 4 commits into from
Feb 29, 2024
Merged

fix: closes #955. fixed issue with stretched #1004

merged 4 commits into from
Feb 29, 2024

Conversation

SyamBabu-M
Copy link
Contributor

@SyamBabu-M SyamBabu-M requested review from AbhishekPAnil and removed request for AbhishekPAnil February 26, 2024 07:44
@aws-amplify-ca-central-1 AWS Amplify (ca-central-1)
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-1004.dla06mbe0wyl7.amplifyapp.com

@SyamBabu-M SyamBabu-M linked an issue Feb 26, 2024 that may be closed by this pull request
People: images on list page in CMS look stretched #955
Closed
Base automatically changed from develop to main February 26, 2024 14:28
@saumier
Copy link
Member

saumier commented Feb 26, 2024 •
edited
Loading

@SyamBabu-M This was fixed by a291d43 but then a few hours later broken by 281393b

The thumbnail images should be object-fit: cover to avoid distortion (stretching) and to look good in the UI. Otherwise the images in the list look like different sizes. See https://developer.mozilla.org/en-US/docs/Web/CSS/object-fit.

In the detail screen the image should be object-fit: contain so the entire large image can be seen in the box and not be cropped.

@AbhishekPAnil AbhishekPAnil changed the base branch from main to develop February 27, 2024 05:31
@AbhishekPAnil AbhishekPAnil merged commit 20108b0 into develop Feb 29, 2024
1 check passed
@AbhishekPAnil AbhishekPAnil deleted the bugfix/issue-955 branch February 29, 2024 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhishekPAnil AbhishekPAnil Awaiting requested review from AbhishekPAnil

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

People: images on list page in CMS look stretched
3 participants
@SyamBabu-M @saumier @AbhishekPAnil