Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

People: images on list page in CMS look stretched #955

Closed
troughc opened this issue Feb 9, 2024 · 2 comments · Fixed by #1004
Closed

People: images on list page in CMS look stretched #955

troughc opened this issue Feb 9, 2024 · 2 comments · Fixed by #1004
Assignees
Labels
bug Something isn't working

Comments

@troughc
Copy link
Contributor

troughc commented Feb 9, 2024

images of people in Signe Laval people list look elongated

Image

@troughc troughc self-assigned this Feb 9, 2024
@troughc troughc added bug Something isn't working to be scheduled Work has been estimated, now it needs a priority and milstone and removed to be scheduled Work has been estimated, now it needs a priority and milstone labels Feb 9, 2024
@troughc troughc assigned AbhishekPAnil and unassigned troughc Feb 13, 2024
@troughc troughc added this to the February Release milestone Feb 15, 2024
@SyamBabu-M SyamBabu-M linked a pull request Feb 26, 2024 that will close this issue
@SyamBabu-M SyamBabu-M assigned saumier and unassigned SyamBabu-M Feb 26, 2024
@saumier saumier assigned SyamBabu-M and unassigned saumier Feb 26, 2024
@SyamBabu-M
Copy link
Contributor

@saumier @AbhishekPAnil
I looked into the comments of PR. And I have updated the styles as you mentioned.

I just want to mention that adding object-fit: cover will make the image fill the entire 40*40 container. But this can cause a portion of the image to be cropped if the images are not square in dimension.

Image

object-fit: contain on the other hand will ensure that the entire image that the user uploaded will be shown.

@SyamBabu-M SyamBabu-M assigned saumier and unassigned SyamBabu-M Feb 27, 2024
@saumier
Copy link
Member

saumier commented Feb 28, 2024

@SyamBabu-M Looks good. Since the images are all different sizes, the thumbnail view would loose a consistent look and feel. I think using object-fit: flow on the list with the small thumbnails, like in events list, is the way to go. And the full image can be seen on the details view with object-fit: contain.

@saumier saumier closed this as completed Feb 28, 2024
@saumier saumier reopened this Feb 28, 2024
AbhishekPAnil added a commit that referenced this issue Feb 29, 2024
fix: closes #955. fixed issue with stretched
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants