deprecation updates ahead of 9.0.0 #2240
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
defineStep
- at the time the direction seemed to be to eventually make strict keywords the only behaviour. However there is not a consensus across platforms for doing that, so on that basis it should only be an option. ThePickleStep
model has an 'Unknown' value so we can use that fordefineStep
and just throw if you try to use it with strict keywords. Finally, a user raised a separate concern in defense ofdefineStep
from a linguistics perspective. So overall I think there's no longer a case to remove this.Deprecate the export ofJsonFormatter
class - currently most of the built-in formatter classes are exported like this but I think they should mostly be considered implementation details. When we tackle make json formatter reusable outside cucumber-js #2239 we'll rewrite this formatter, probably in the new "plugin"-style format we've discussed, so we should get this off the entry point as soon as we can.🏷️ What kind of change is this?
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.