remove generator snippet interface (#2241)

cucumber · Feb 16, 2023 · 90ebb80 · 90ebb80
1 parent 260e943
commit 90ebb80
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 29 deletions.
diff --git a/features/step_definition_snippets_interfaces.feature b/features/step_definition_snippets_interfaces.feature
@@ -25,7 +25,6 @@ Feature: step definition snippets custom syntax
     Examples:
       | INTERFACE   | SNIPPET_FUNCTION_KEYWORD_AND_PARAMETERS | SNIPPET_IMPLEMENTATION            |
       | callback    | function (callback)                     | callback(null, 'pending')         |
-      | generator   | function *()                            | return 'pending'                  |
       | promise     | function ()                             | return Promise.resolve('pending') |
       | async-await | async function ()                       | return 'pending'                  |
       | synchronous | function ()                             | return 'pending'                  |
diff --git a/src/formatter/step_definition_snippet_builder/javascript_snippet_syntax.ts b/src/formatter/step_definition_snippet_builder/javascript_snippet_syntax.ts
@@ -23,8 +23,6 @@ export default class JavaScriptSnippetSyntax implements ISnippetSnytax {
     let functionKeyword = 'function '
     if (this.snippetInterface === SnippetInterface.AsyncAwait) {
       functionKeyword = 'async ' + functionKeyword
-    } else if (this.snippetInterface === SnippetInterface.Generator) {
-      functionKeyword += '*'
     }
 
     let implementation: string

diff --git a/src/formatter/step_definition_snippet_builder/javascript_snippet_syntax_spec.ts b/src/formatter/step_definition_snippet_builder/javascript_snippet_syntax_spec.ts
@@ -45,31 +45,6 @@ describe('JavascriptSnippetSyntax', () => {
       })
     })
 
-    describe('generator interface', () => {
-      it('returns the proper snippet', function () {
-        // Arrange
-        const syntax = new JavascriptSnippetSyntax(SnippetInterface.Generator)
-        const buildOptions: ISnippetSyntaxBuildOptions = {
-          comment: 'comment',
-          functionName: 'functionName',
-          generatedExpressions: generateExpressions('"abc" def "ghi"'),
-          stepParameterNames: [],
-        }
-
-        // Act
-        const result = syntax.build(buildOptions)
-
-        // Assert
-        expect(result).to.eql(
-          reindent(`
-            functionName('{string} def {string}', function *(string, string2) {
-              // comment
-              return 'pending';
-            });`)
-        )
-      })
-    })
-
     describe('promise interface', () => {
       it('returns the proper snippet', function () {
         // Arrange

diff --git a/src/formatter/step_definition_snippet_builder/snippet_syntax.ts b/src/formatter/step_definition_snippet_builder/snippet_syntax.ts
@@ -3,7 +3,6 @@ import { GeneratedExpression } from '@cucumber/cucumber-expressions'
 export enum SnippetInterface {
   AsyncAwait = 'async-await',
   Callback = 'callback',
-  Generator = 'generator',
   Promise = 'promise',
   Synchronous = 'synchronous',
 }