Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubocop #719

Merged
merged 2 commits into from
Jul 5, 2020
Merged

Update rubocop #719

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
28d01ba
Enable new cops
mvz Jul 4, 2020
62e4535
Regenerate RuboCop TODO file
mvz Jul 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion .rubocop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,13 +27,15 @@ Style/FrozenStringLiteralComment:
Layout/LineLength:
Max: 94

# Enable new cops from RuboCop 0.80, 0.81 and 0.84
# Enable new cops from RuboCop 0.80 - 0.86
Layout/EmptyLinesAroundAttributeAccessor:
Enabled: true
Layout/SpaceAroundMethodCallOperator:
Enabled: true
Lint/DeprecatedOpenSSLConstant:
Enabled: true
Lint/MixedRegexpCaptureTypes:
Enabled: true
Lint/RaiseException:
Enabled: true
Lint/StructNewOverride:
Expand All @@ -46,6 +48,12 @@ Style/HashTransformKeys:
Enabled: true
Style/HashTransformValues:
Enabled: true
Style/RedundantFetchBlock:
Enabled: true
Style/RedundantRegexpCharacterClass:
Enabled: true
Style/RedundantRegexpEscape:
Enabled: true
Style/SlicingWithRange:
Enabled: true

Expand Down
12 changes: 6 additions & 6 deletions .rubocop_todo.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# This configuration was generated by
# `rubocop --auto-gen-config`
# on 2020-05-31 23:12:24 +0200 using RuboCop version 0.84.0.
# on 2020-07-04 12:40:19 UTC using RuboCop version 0.86.0.
# The point is for the user to remove these configuration records
# one by one as the offenses are removed from the code base.
# Note that changes in the inspected code, or installation of new
Expand All @@ -18,7 +18,7 @@ Lint/Void:
- 'lib/aruba/platforms/announcer.rb'
- 'lib/aruba/platforms/unix_environment_variables.rb'

# Offense count: 26
# Offense count: 25
# Configuration parameters: IgnoredMethods.
Metrics/AbcSize:
Max: 116
Expand All @@ -37,7 +37,7 @@ Metrics/ClassLength:
# Offense count: 5
# Configuration parameters: IgnoredMethods.
Metrics/CyclomaticComplexity:
Max: 12
Max: 13

# Offense count: 28
# Configuration parameters: CountComments, ExcludedMethods.
Expand Down Expand Up @@ -95,7 +95,7 @@ Performance/Caller:
Exclude:
- 'lib/aruba/platforms/unix_platform.rb'

# Offense count: 51
# Offense count: 49
# Configuration parameters: Prefixes.
# Prefixes: when, with, without
RSpec/ContextWording:
Expand Down Expand Up @@ -133,15 +133,15 @@ RSpec/ExampleLength:
- 'spec/aruba/matchers/collection_spec.rb'

# Offense count: 4
# Configuration parameters: CustomTransform, IgnoreMethods.
# Configuration parameters: CustomTransform, IgnoreMethods, SpecSuffixOnly.
RSpec/FilePath:
Exclude:
- 'spec/aruba/platform/windows_environment_variables_spec.rb'
- 'spec/aruba/platforms/command_monitor_spec.rb'
- 'spec/event_bus/name_resolver_spec.rb'
- 'spec/event_bus_spec.rb'

# Offense count: 298
# Offense count: 296
# Configuration parameters: AssignmentOnly.
RSpec/InstanceVariable:
Exclude:
Expand Down