Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rubocop #719

Merged
merged 2 commits into from
Jul 5, 2020
Merged

Update rubocop #719

merged 2 commits into from
Jul 5, 2020

Conversation

mvz
Copy link
Contributor

@mvz mvz commented Jul 4, 2020

Summary

Update RuboCop configuration for RuboCop 0.86.

Details

Enables new cops and regenerates TODO file.

Motivation and Context

RuboCop 0.86 introduced a change to CyclomaticComplexity that increases the complexity score for some methods. This caused the lint task to fail. Regenerating the TODO file resolves this.

How Has This Been Tested?

I ran RuboCop.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (cleanup of codebase without changing any existing functionality)
  • Update documentation

Checklist:

  • I've added tests for my code
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is helpful, and clearly states versions for which things are meant to work. Thanks!

@mvz mvz merged commit 886490e into master Jul 5, 2020
@mvz mvz deleted the update-rubocop branch July 5, 2020 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants