Skip to content
This repository has been archived by the owner on Apr 16, 2020. It is now read-only.

speed up sourcelink test #191

Merged
merged 2 commits into from
Apr 21, 2017
Merged

speed up sourcelink test #191

merged 2 commits into from
Apr 21, 2017

Conversation

mderriey
Copy link
Contributor

@mderriey mderriey commented Apr 3, 2017

Fixes #190

@mderriey
Copy link
Contributor Author

mderriey commented Apr 3, 2017

This is the very first attempt at making sourcelink test a bit faster; it introduces asynchronous checking of documents URLs within a .pdb or a .dll.

Let me know what you think. I'll probably do the same thing with .nupkgs if you're happy with this.

@ctaggart
Copy link
Owner

ctaggart commented Apr 6, 2017

Thank you @mderriey. How much does this speed things up?

@mderriey
Copy link
Contributor Author

mderriey commented Apr 6, 2017

I only tested it on Octokit, I don't know if it qualifies as a good subject for testing.

It did speed things up, however that's based on my personal judgment only, so I don't have any metrics to share.

Do you have a codebase you know know takes some time? I could give it a try, and maybe try to time things.

@mderriey
Copy link
Contributor Author

@ctaggart could you let me know what you'd want done to move this forward?

@ctaggart
Copy link
Owner

@mderriey Some kind of test that shows that performance is improved. Using Octokit with Travis CI or AppVeyor would work. You can simply create a branch that uses a build from this PR.

https://github.com/ctaggart/SourceLink/blob/v2/NuGet.Config

<add key="sourcelink" value="https://ci.appveyor.com/nuget/sourcelink/" />

@mderriey
Copy link
Contributor Author

I can't seem to find a build for this PR on AppVeyor. Am I missing something?

@ctaggart
Copy link
Owner

@mderriey Weird. I just updated the webhook to send pull requests too. Can you push again to your branch?

@mderriey
Copy link
Contributor Author

mderriey commented Apr 19, 2017

OK so I compared AppVeyor builds times.

Before changes:

Link to AppVeyor build Time taken for sourcelink test
0.25.0-PullRequest.1581+31.build.2070 44 seconds
0.25.0-PullRequest.1574+13.build.2045 45 seconds

After changes - using the 2.1.0-b448 version built by this AppVeyor build:

Link to AppVeyor build Time taken for sourcelink test
0.25.0-PullRequest.1587+32.build.2079 5 seconds
0.25.0-PullRequest.1587+33.build.2080 4 seconds

The links go to the relevant lines of the builds that show the time taken for the Cake task that runs sourcelink test.

@ctaggart
Copy link
Owner

That is great! Did you have more changes to make?

@mderriey
Copy link
Contributor Author

Unless you can think of something else we could try to improve, no.

I didn't put much thought into the design of the changes, either, just went async where you said we could do it. Feel free to review the changes in depth and let me know if you see anything you might want done another way.

@ctaggart ctaggart changed the title [WIP] - Speed up sourcelink test speed up sourcelink test Apr 21, 2017
@ctaggart
Copy link
Owner

Testing a Rx.NET package on my laptop drops the test time from 50 seconds to 13 seconds. Once again, great job. dotnet/reactive#393

@ctaggart ctaggart merged commit 6153a83 into ctaggart:v2 Apr 21, 2017
@ctaggart ctaggart added this to the 2.1.1 milestone May 2, 2017
@ctaggart
Copy link
Owner

ctaggart commented May 2, 2017

This will be in version 2.1.1.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants