Skip to content
This repository has been archived by the owner on Apr 16, 2020. It is now read-only.

speed up sourcelink test #190

Closed
ctaggart opened this issue Apr 2, 2017 · 3 comments
Closed

speed up sourcelink test #190

ctaggart opened this issue Apr 2, 2017 · 3 comments

Comments

@ctaggart
Copy link
Owner

ctaggart commented Apr 2, 2017

When dotnet sourcelink test is currently run, it downloads all of the source files sequentially and synchronously. This could be made asynchronous and parallel.

Current code:

                foreach (var doc in GetDocumentsWithUrls(drp))
                {
                    if(doc.Url != null)
                    {
                        HashUrl(hc, doc);
@mderriey
Copy link
Contributor

mderriey commented Apr 2, 2017

Hey @ctaggart I'm keen on giving this a go.

Have you already thought about how you'd like this to be implemented?

@ctaggart
Copy link
Owner Author

ctaggart commented Apr 3, 2017

@mderriey I have not. Give it a go. There may be multiple files in a nupkg to check urls for.

@mderriey
Copy link
Contributor

mderriey commented Apr 3, 2017

OK, cool.

ctaggart pushed a commit that referenced this issue Apr 21, 2017
* Check document hash asynchronously

Fixes #190

* empty commit to trigger an AppVeyor build
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants