Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing imports for event sources #991

Merged
merged 1 commit into from
Feb 27, 2019
Merged

Add missing imports for event sources #991

merged 1 commit into from
Feb 27, 2019

Conversation

maxnoe
Copy link
Member

@maxnoe maxnoe commented Feb 27, 2019

Fixes #990

@maxnoe maxnoe mentioned this pull request Feb 27, 2019
Closed
@codecov
Copy link

codecov bot commented Feb 27, 2019 •
edited
Loading

Codecov Report

Merging #991 into master will increase coverage by 0.74%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #991      +/-   ##
==========================================
+ Coverage   78.19%   78.93%   +0.74%     
==========================================
  Files         194      195       +1     
  Lines       11313    11328      +15     
==========================================
+ Hits         8846     8942      +96     
+ Misses       2467     2386      -81
Impacted Files Coverage Δ
ctapipe/io/lsteventsource.py 17.3% <ø> (+17.3%) ⬆️
ctapipe/io/tests/test_available_sources.py 100% <100%> (ø)
ctapipe/io/__init__.py 100% <100%> (ø) ⬆️
ctapipe/io/nectarcameventsource.py 18.34% <0%> (+18.34%) ⬆️
ctapipe/tools/camdemo.py 76.13% <0%> (+20.45%) ⬆️
ctapipe/io/sst1meventsource.py 21.62% <0%> (+21.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dcb64d4...4853f1b. Read the comment docs.

@kbruegge kbruegge merged commit 6e6ba5e into master Feb 27, 2019
@maxnoe maxnoe deleted the fix_missing_imports branch February 27, 2019 17:58
kosack added a commit that referenced this pull request Mar 8, 2019
@kosack
Use conda packages instead of pip (#989)
13efd83 
* removed PIP installs, and use conda instead

* updated all env files

* added back pyhessio, needed for tests

* Add missing imports for event sources (#991)

* Pass allowed_tels to simtel event source (#987)

* removed PIP installs, and use conda instead

* updated all env files

* added back pyhessio, needed for tests

* removed pyhessio from environment.yml (users don't need it, just tests)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kosack kosack kosack approved these changes

@kbruegge kbruegge kbruegge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxnoe @kbruegge @kosack