Pass allowed_tels down to eventio in simtel event source #987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxnoe
changed the title
Codecov Report
@@ Coverage Diff @@
## master #987 +/- ##
==========================================
+ Coverage 78.19% 78.35% +0.15%
==========================================
Files 194 194
Lines 11313 11313
==========================================
+ Hits 8846 8864 +18
+ Misses 2467 2449 -18
Continue to review full report at Codecov.
|
kosack
approved these changes
Feb 27, 2019
kbruegge
approved these changes
Feb 27, 2019
kosack
added a commit
that referenced
this pull request
Mar 8, 2019
* removed PIP installs, and use conda instead * updated all env files * added back pyhessio, needed for tests * Add missing imports for event sources (#991) * Pass allowed_tels to simtel event source (#987) * removed PIP installs, and use conda instead * updated all env files * added back pyhessio, needed for tests * removed pyhessio from environment.yml (users don't need it, just tests)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passes the allowed_tels down to the
SimTelFile, so it get's a little faster when reading only a few telescopes.