Update Timing Parameters #799
Conversation
LukasNickel
commented
Oct 10, 2018
LukasNickel
commented
- use container for output
- use geometry, peakpos and hillas_parameters as input
- adapt test
LukasNickel
force-pushed
the
update_timing
branch
from
8b40809 to
b74f470
Compare
|
We just rebased our stuff onto master, why was the merge needed? |
|
@LukasNickel is a new master student in Dortmund, btw. |
LukasNickel
force-pushed
the
update_timing
branch
from
73b7b1f to
27e2b8c
Compare
* use container for output * use geometry, peakpos and hillas_parameters as input * adapt tests
LukasNickel
force-pushed
the
update_timing
branch
from
27e2b8c to
20890d7
Compare
Codecov Report
@@ Coverage Diff @@
## master #799 +/- ##
==========================================
+ Coverage 71.92% 71.94% +0.01%
==========================================
Files 204 204
Lines 11039 11038 -1
==========================================
+ Hits 7940 7941 +1
+ Misses 3099 3097 -2
Continue to review full report at Codecov.
|
|
I'm cannot explain why coverage of |
Looked into this a little bit, with Max. The missed part is the body of the To us this smells a bit like a possible issue with the mpl backend ... GUI testing is just hard (DNs personal opinion) |
|
@LukasNickel can you fix the stuff that codacy complains about? |
Going to do that asap. |
Yes, not related to this PR. |
* removed unused imports * fixed whitespace issues
LukasNickel
force-pushed
the
update_timing
branch
from
7cb7f21 to
c3510f3
Compare
that seems to be a false positive, so just ignore it. Not sure why it came up in this PR. |
* master: (60 commits) Add test that shows slicing breaks cam geom and fix it (cta-observatory#782) fix ctapipe build failure (cta-observatory#811) fix package name for yaml (should be pyyaml) (cta-observatory#810) Implement number of islands (cta-observatory#801) fixed ranges of cam-display so they correspond to fixed toymodel sims (cta-observatory#808) Fix unknown section example warning (cta-observatory#800) Fix timing parameters for case when there are negative values in image (cta-observatory#804) Update Timing Parameters (cta-observatory#799) speed up unit tests that use test_event fixture (cta-observatory#798) Add unit to h_max in HillasReconstructor (cta-observatory#797) Codacy code style improvements (cta-observatory#796) Minor changes: mostly deprecationwarning fixes (cta-observatory#787) Array plotting (cta-observatory#784) added a config file for github change-drafter plugin (cta-observatory#795) Simple HESS adaptations (cta-observatory#794) add test for sliced geometries for hillas calculation (cta-observatory#781) Impact intersection (cta-observatory#778) updated main documentation page (cta-observatory#792) Implement concentration image features (cta-observatory#791) Fix bad builds by changing channel name (missing pyqt package) (cta-observatory#793) ... # Conflicts: # ctapipe/calib/camera/dl1.py
